[docs] Sticky Navigation #314

adekunleoduye · 2019-03-28T11:50:21Z

Summary:
Documentation nav becomes sticky when user scrolls down the page.

Screenshot:

To dos:

Removes inline styles from sass.js and put them into a sass files
abstract function out of sass.js into documentation.js
Give background color to nav
Add shim to content when nav is sticky

Closes #268

houndci-bot · 2019-03-28T11:50:28Z

source/assets/js/sass.js

+      );
+    }),
+    (a.fn.smoothScroll.defaults = c);
+});


Expected an assignment or function call and instead saw an expression.

houndci-bot · 2019-03-28T11:50:28Z

source/assets/js/sass.js

+          .replace(/\/$/, "")
+      );
+    }),
+    (a.fn.smoothScroll.defaults = c);


Expected an assignment or function call and instead saw an expression.

houndci-bot · 2019-03-28T11:50:28Z

source/assets/js/sass.js

+        }
+      }),
+      e.step && (q.step = e.step),
+      h.length ? h.stop().animate(p, q) : g(e);


Expected an assignment or function call and instead saw an expression.

houndci-bot · 2019-03-28T11:50:28Z

source/assets/js/sass.js

+        : (h = a("html, body").firstScrollable(e.direction)),
+      e.beforeScroll.call(h, e),
+      (l = k.px
+        ? k


Misleading line break before '?'; readers may interpret this as an expression boundary.

houndci-bot · 2019-03-28T11:50:28Z

source/assets/js/sass.js

+        d && (k = f(d))),
+      (o = "left" === e.direction ? "scrollLeft" : o),
+      e.scrollElement
+        ? ((h = e.scrollElement),


Misleading line break before '?'; readers may interpret this as an expression boundary.

houndci-bot · 2019-03-28T11:50:29Z

source/assets/js/sass.js

+          ) {
+            for (; l && j < h.length; ) f.is(c(h[j++])) && (l = !1);
+            for (; l && k < i.length; ) f.closest(i[k++]).length && (l = !1);
+          } else l = !1;


Expected '{' and instead saw 'l'.

houndci-bot · 2019-03-28T11:50:29Z

source/assets/js/sass.js

+            (r && !a(r).length && (l = !1), g.scrollTarget || (p && q && r))
+          ) {
+            for (; l && j < h.length; ) f.is(c(h[j++])) && (l = !1);
+            for (; l && k < i.length; ) f.closest(i[k++]).length && (l = !1);


Expected '{' and instead saw 'f'.
Expected an assignment or function call and instead saw an expression.

houndci-bot · 2019-03-28T11:50:30Z

source/assets/js/sass.js

+          if (
+            (r && !a(r).length && (l = !1), g.scrollTarget || (p && q && r))
+          ) {
+            for (; l && j < h.length; ) f.is(c(h[j++])) && (l = !1);


Expected '{' and instead saw 'f'.
Expected an assignment or function call and instead saw an expression.

houndci-bot · 2019-03-28T11:50:30Z

source/assets/js/sass.js

+    smoothScroll: function(b, c) {
+      if ("options" === (b = b || {}))
+        return c
+          ? this.each(function() {


Misleading line break before '?'; readers may interpret this as an expression boundary.

houndci-bot · 2019-03-28T11:50:30Z

source/assets/js/sass.js

+    },
+    smoothScroll: function(b, c) {
+      if ("options" === (b = b || {}))
+        return c


Expected '{' and instead saw 'return'.

jina · 2019-03-28T20:38:23Z

It looks like the content jumps to the left, assuming because the nav is pulled out of the flow. Perhaps a shim of some sort in its place so that the content doesn't shift over?

adekunleoduye · 2019-03-28T21:04:39Z

@jina That sounds good to me. I'll added that to the todo list and update that PR.

nex3 · 2019-03-28T22:48:01Z

When I load this up and go to /documentation, when I scroll down far enough it just jumps back to the top of the page in a very jarring way.

When I go to /documentation/syntax/structure and scroll down, the page nav starts overlapping with the global nav:

Are there plans for making the top-level nav sections expandable? What about for making page-level navs sticky?

I think it may be cleaner to just have the scrollbar present all the time, rather than flashing into existence once the user scrolls down far enough.

d2s · 2019-04-23T17:51:28Z

Gemfile

@@ -1,5 +1,5 @@
 source "https://rubygems.org"
-ruby "2.5.3"
+ruby "2.5.1"


Is there a good reason for why the ruby "2.5.3" version was replaced with an older ruby "2.5.1" version?

No specific reason, I was having trouble installing ruby "2.5.3"

houndci-bot · 2019-04-30T23:18:53Z

source/assets/js/sass.js

+            this === document.documentElement &&
+              "smooth" === a(this).css("scrollBehavior") &&
+              (c = [this]),
+              c.length || "BODY" !== this.nodeName || (c = [this]);


Expected an assignment or function call and instead saw an expression.

houndci-bot · 2019-04-30T23:18:53Z

source/assets/js/sass.js

+            return !document.scrollingElement ||
+              (this !== document.documentElement && this !== document.body)
+              ? void (b[e]() > 0
+                  ? c.push(this)


Misleading line break before '?'; readers may interpret this as an expression boundary.

houndci-bot · 2019-04-30T23:18:53Z

source/assets/js/sass.js

+          if (this !== document && this !== window)
+            return !document.scrollingElement ||
+              (this !== document.documentElement && this !== document.body)
+              ? void (b[e]() > 0


Misleading line break before '?'; readers may interpret this as an expression boundary.

houndci-bot · 2019-04-30T23:18:53Z

source/assets/js/sass.js

+        this.each(function() {
+          var b = a(this);
+          if (this !== document && this !== window)
+            return !document.scrollingElement ||


Expected '{' and instead saw 'return'.

houndci-bot · 2019-04-30T23:18:53Z

source/assets/js/sass.js

+    ? define(["jquery"], a)
+    : a(
+        "object" == typeof module && module.exports ? require("jquery") : jQuery
+      );


Expected an assignment or function call and instead saw an expression.

houndci-bot · 2019-04-30T23:18:53Z

source/assets/js/sass.js

+  "function" == typeof define && define.amd
+    ? define(["jquery"], a)
+    : a(
+        "object" == typeof module && module.exports ? require("jquery") : jQuery


'require' is not defined.

houndci-bot · 2019-04-30T23:18:53Z

source/assets/js/sass.js

@@ -5,22 +5,209 @@
 * Licensed MIT
 */

+!(function(a) {
+  "function" == typeof define && define.amd
+    ? define(["jquery"], a)


'define' is not defined.
Misleading line break before '?'; readers may interpret this as an expression boundary.

houndci-bot · 2019-04-30T23:18:54Z

source/assets/js/sass.js

@@ -5,22 +5,209 @@
 * Licensed MIT
 */

+!(function(a) {
+  "function" == typeof define && define.amd


'define' is not defined.

adekunleoduye · 2019-09-30T11:15:14Z

Since this PR is stale, I'm going to close it and open a new one.

[docNav] First prototype of sticky navigation for documentation

3567bd9

houndci-bot reviewed Mar 28, 2019

View reviewed changes

nex3 force-pushed the wip.reference branch 3 times, most recently from ea9b6ed to b1ee5c8 Compare April 23, 2019 16:47

d2s reviewed Apr 23, 2019

View reviewed changes

[ruby-version] reverted back to 2.5.3

0c2c7d0

houndci-bot reviewed Apr 30, 2019

View reviewed changes

adekunleoduye closed this Sep 30, 2019

adekunleoduye deleted the feat/stickyDocNav branch September 30, 2019 11:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docs] Sticky Navigation #314

[docs] Sticky Navigation #314

adekunleoduye commented Mar 28, 2019 •

edited

Loading

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

jina commented Mar 28, 2019

adekunleoduye commented Mar 28, 2019

nex3 commented Mar 28, 2019

d2s Apr 23, 2019

adekunleoduye Apr 30, 2019

houndci-bot Apr 30, 2019

houndci-bot Apr 30, 2019

houndci-bot Apr 30, 2019

houndci-bot Apr 30, 2019

houndci-bot Apr 30, 2019

houndci-bot Apr 30, 2019

houndci-bot Apr 30, 2019

houndci-bot Apr 30, 2019

adekunleoduye commented Sep 30, 2019

[docs] Sticky Navigation #314

[docs] Sticky Navigation #314

Conversation

adekunleoduye commented Mar 28, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jina commented Mar 28, 2019

adekunleoduye commented Mar 28, 2019

nex3 commented Mar 28, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adekunleoduye commented Sep 30, 2019

adekunleoduye commented Mar 28, 2019 •

edited

Loading