Spacing improvement #496
Merged
Spacing improvement #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a spacer to the follow button on footer (mobile only) - Added missing spacer from page titles (mobile + desktop)
|
Can I see a screenshot of these on a larger screen? (@nex3 for some reason this didn't deploy so I could preview) |
|
I believe it only deploys for repo collaborators, so that people can't use the preview to just host whatever site on our Heroku instance. |
|
gotcha. makes sense! @danielhaim1 so yeah the screenshots of how this looks on a larger screen would be super helpful. thanks! |
jina
requested changes
Oct 27, 2020
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
- Added a spacer to the follow button on footer (mobile only) - Added missing spacer from page titles (mobile + desktop)
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
- Added a spacer to the follow button on footer (mobile only) - Added missing spacer from page titles (mobile + desktop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Nav (before/after)
Footer (before/after)