Fix redirects #649
Merged
Fix redirects #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're now serving the website fully statically, we need to use meta redirects rather than relying on our server configuration. Closes #650
Goodwine
approved these changes
Jun 22, 2022
|
|
||
| Dir['source/documentation/breaking-changes/**'].each do |file| | ||
| basename = File.basename(file).gsub(/\..*/, '') | ||
| redirect "d/#{basename}.html", to: "/documentation/breaking-changes/#{basename}" |
There was a problem hiding this comment.
Only nitpick is that before some redirects were any /d/whatever to /doc.../break.../whatever, regardless of whether the url was known or not, and now it redirects on known URLs only
(Same on others)
I assume that's intended because it would throw 404 regardless?
There was a problem hiding this comment.
These redirects are actually compiled down to HTML pages with <meta http-equiv="refresh"> tags, so we unfortunately can't do wildcard redirects anymore. Otherwise I'd keep them if I could.
Closed
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
Since we're now serving the website fully statically, we need to use meta redirects rather than relying on our server configuration. Closes sass#650
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
Since we're now serving the website fully statically, we need to use meta redirects rather than relying on our server configuration. Closes sass#650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're now serving the website fully statically, we need to use
meta redirects rather than relying on our server configuration.