Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the moz-document breaking change on the sass website. #667

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Document the moz-document breaking change on the sass website. #667

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f3180e
Document the moz-document breaking change on the sass website.
stof Sep 3, 2022
127549b
Apply suggestions from code review
Goodwine Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions data/documentation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ toc:
- Media Queries Level 4: /documentation/breaking-changes/media-logic
- <code>/</code> as Division: /documentation/breaking-changes/slash-div
- Color Units: /documentation/breaking-changes/color-units
- <code>-moz-document</code>: /documentation/breaking-changes/moz-document
- Extending Compound Selectors: /documentation/breaking-changes/extend-compound
- CSS Variable Syntax: /documentation/breaking-changes/css-vars
- Command Line: /documentation/cli
Expand Down
3 changes: 3 additions & 0 deletions source/documentation/breaking-changes.html.md.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ These breaking changes are coming soon or have recently been released:
* [Color functions are becoming more strict about
units](breaking-changes/color-units) beginning in Dart Sass 1.32.0.

* [Parsing the special syntax of `@-moz-document` will be
invalid](breaking-changes/moz-document) beginning in Dart Sass 1.7.2.

* [Compound selectors could not be extended](breaking-changes/extend-compound)
in Dart Sass 1.0.0 and Ruby Sass 4.0.0.

Expand Down
38 changes: 38 additions & 0 deletions source/documentation/breaking-changes/moz-document.md.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
title: "Breaking Change: -moz-document"
introduction: >
Firefox used to have a @-moz-document rule requiring a special parsing. As
Goodwine marked this conversation as resolved.
Show resolved Hide resolved
support is removed from Firefox, Sass is in the process of removing support
for parsing them.
---

Sass has historically supported a special parsing for the `@-moz-document` rule.
As [Firefox dropped support for them], Sass will also drop support for the special
parsing.
Goodwine marked this conversation as resolved.
Show resolved Hide resolved

[Firefox dropped support for them]: https://web.archive.org/web/20200528221656/https://www.fxsitecompat.dev/en-CA/docs/2018/moz-document-support-has-been-dropped-except-for-empty-url-prefix/


**There is one exception**: an empty url prefix function is still allowed, as
that's used in a hack targetting Firefox.

<% example do %>
@-moz-document url-prefix() {
.error {
color: red;
}
}
===
@-moz-document url-prefix()
.error
color: red
<% end %>

## Transition Period

<% impl_status dart: '1.7.2', libsass: false, ruby: false %>

First, we'll emit deprecation warnings for all usages of `@-moz-document`
except for the empty url-prefix hack.

In Dart Sass 2.0, `@-moz-document` will be treated as an unknown at-rule.