Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add More Info on Equality Operators page #677

Closed
wants to merge 2 commits into from
Closed

fix: Add More Info on Equality Operators page #677

wants to merge 2 commits into from

Conversation

custardcream98
Copy link

@custardcream98 custardcream98 commented Sep 28, 2022

Issue

Resolves: #676

Summery

@debug 1 != 1px; is false, and @debug 1 != 1rem; is also false.

So I've added some and fixed comment.

@custardcream98 custardcream98 changed the title fix: typo on Equality Operators page fix: Add More Info on Equality Operators page Sep 30, 2022
@custardcream98
Copy link
Author

I've found out that it wasn't a typo, so I've added some more for those who get confused like me. 😂😂

@custardcream98
Copy link
Author

So,

@debug 1 != 1px;

is false on LibSass version under 3.6.5
and true on LibSass version 3.6.5 thanks to this change
(and also true on lateset Dart Sass)

@nex3 nex3 self-assigned this Oct 3, 2022
@nex3
Copy link
Contributor

nex3 commented Oct 3, 2022

Thanks for the contribution, but we've already got info about the change in equality behavior on that page, in our standardized component for describing cross-version/-implementation differences:

<% impl_status dart: true, libsass: false, ruby: '4.0.0 (unreleased)', feature: "Unitless Equality" do %>
LibSass and older versions of Ruby Sass consider numbers without units to be
equal to the same numbers with any units. This behavior was deprecated and has
been removed from more recently releases because it violates [transitivity][].
[transitivity]: https://en.wikipedia.org/wiki/Transitive_relation
<% end %>

@nex3 nex3 closed this Oct 3, 2022
@custardcream98
Copy link
Author

Oh, I didn't notice that toggle button. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect comment on document's 'Equality' part
2 participants