Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple typos #703

Merged
merged 5 commits into from
Mar 22, 2023
Merged

Fix multiple typos #703

merged 5 commits into from
Mar 22, 2023

Conversation

ericmutta
Copy link
Contributor

See commits for details 馃憤

PS: the contribution guide recommends drinking whisky...does the team supply said whisky for new contributors? 馃槃

@nex3 nex3 requested a review from Goodwine March 20, 2023 20:52
Goodwine
Goodwine reviewed Mar 21, 2023
View reviewed changes
Copy link
Member

@Goodwine Goodwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 馃榾

source/documentation/at-rules/import.html.md.erb Outdated Show resolved Hide resolved
@Goodwine Goodwine self-requested a review March 21, 2023 21:32
Goodwine
Goodwine approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@Goodwine Goodwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change was small enough, so I just went ahead and committed it into the PR. I'll merge now

@Goodwine
Copy link
Member

Blocked on #705

@ericmutta
Copy link
Contributor Author

Thanks @Goodwine for following up! 馃檹

ericmutta and others added 5 commits March 22, 2023 13:58
@ericmutta @Goodwine
Fix typo in import.html.md.erb
5db9e3b 
The following sentence:

> ...libraries must **prefix to all** their members...

Should read:

> ...libraries must **add a prefix to all** their members...
@ericmutta @Goodwine
Fix typo in comments.html.md.erb
cdc9a8e 
The following:

> Because the **extend** of the comment...

Should read:

> Because the **extent** of the comment...
@ericmutta @Goodwine
Fix typo in string.html.md.erb
25e75b9 
The sentence:

> ...relying on **this** operators...

Should read:

> ...relying on **these** operators...
@ericmutta @Goodwine
Fix typo in string.html.md.erb
4a715cd 
The following sentence:

> If **of** `$index` is higher...

Should read:

> If `$index` is higher...
@Goodwine
Reflow source/documentation/at-rules/import.html.md.erb
04427d9
@Goodwine Goodwine merged commit abaee7e into sass:main Mar 22, 2023
@ericmutta ericmutta deleted the patch-2 branch March 23, 2023 07:03
jgerigmeyer added a commit to oddbird/sass-site that referenced this pull request Mar 29, 2023
@jgerigmeyer
Merge branch 'main' of github.com:sass/sass-site
c1e5da4 
* 'main' of github.com:sass/sass-site:
  Document the floating-point numbers spec (sass#708)
  Cut a release for a new Dart Sass version
  Document constants in calculations (sass#707)
  Fix redirects for random-with-units and color-units (sass#706)
  Fix multiple typos (sass#703)
  Revert "Bump nokogiri from 1.12.5 to 1.13.10 (sass#699)" (sass#705)
  Bump nokogiri from 1.12.5 to 1.13.10 (sass#699)
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
  Document --fatal-deprecation (sass#702)
  Partially roll back sass#698
  Document string.split()
  Bump versions of GitHub actions (sass#698)
  Fix broken markdown link in meta.function-exists (sass#697)
  Remove unmaintained links (sass#696)
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024
@ericmutta @Goodwine
Fix multiple typos (sass#703)
37f7426 
* Fix typo in import.html.md.erb

The following sentence:

> ...libraries must **prefix to all** their members...

Should read:

> ...libraries must **add a prefix to all** their members...

* Fix typo in comments.html.md.erb

The following:

> Because the **extend** of the comment...

Should read:

> Because the **extent** of the comment...

* Fix typo in string.html.md.erb

The sentence:

> ...relying on **this** operators...

Should read:

> ...relying on **these** operators...

* Fix typo in string.html.md.erb

The following sentence:

> If **of** `$index` is higher...

Should read:

> If `$index` is higher...

* Reflow source/documentation/at-rules/import.html.md.erb

---------

Co-authored-by: Goodwine <2022649+Goodwine@users.noreply.github.com>
asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024
@jgerigmeyer
Merge branch 'main' of github.com:sass/sass-site
377c63a 
* 'main' of github.com:sass/sass-site:
  Document the floating-point numbers spec (sass#708)
  Cut a release for a new Dart Sass version
  Document constants in calculations (sass#707)
  Fix redirects for random-with-units and color-units (sass#706)
  Fix multiple typos (sass#703)
  Revert "Bump nokogiri from 1.12.5 to 1.13.10 (sass#699)" (sass#705)
  Bump nokogiri from 1.12.5 to 1.13.10 (sass#699)
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
  Document --fatal-deprecation (sass#702)
  Partially roll back sass#698
  Document string.split()
  Bump versions of GitHub actions (sass#698)
  Fix broken markdown link in meta.function-exists (sass#697)
  Remove unmaintained links (sass#696)
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024
@ericmutta @Goodwine
Fix multiple typos (sass#703)
c3deb6e 
* Fix typo in import.html.md.erb

The following sentence:

> ...libraries must **prefix to all** their members...

Should read:

> ...libraries must **add a prefix to all** their members...

* Fix typo in comments.html.md.erb

The following:

> Because the **extend** of the comment...

Should read:

> Because the **extent** of the comment...

* Fix typo in string.html.md.erb

The sentence:

> ...relying on **this** operators...

Should read:

> ...relying on **these** operators...

* Fix typo in string.html.md.erb

The following sentence:

> If **of** `$index` is higher...

Should read:

> If `$index` is higher...

* Reflow source/documentation/at-rules/import.html.md.erb

---------

Co-authored-by: Goodwine <2022649+Goodwine@users.noreply.github.com>
asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024
@jgerigmeyer
Merge branch 'main' of github.com:sass/sass-site
44ca65e 
* 'main' of github.com:sass/sass-site:
  Document the floating-point numbers spec (sass#708)
  Cut a release for a new Dart Sass version
  Document constants in calculations (sass#707)
  Fix redirects for random-with-units and color-units (sass#706)
  Fix multiple typos (sass#703)
  Revert "Bump nokogiri from 1.12.5 to 1.13.10 (sass#699)" (sass#705)
  Bump nokogiri from 1.12.5 to 1.13.10 (sass#699)
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
  Document --fatal-deprecation (sass#702)
  Partially roll back sass#698
  Document string.split()
  Bump versions of GitHub actions (sass#698)
  Fix broken markdown link in meta.function-exists (sass#697)
  Remove unmaintained links (sass#696)
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
  Cut a release for a new Dart Sass version
@Ganjahmanvenenodedios Ganjahmanvenenodedios mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goodwine Goodwine Goodwine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericmutta @Goodwine