Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): correct default import example about default export #792

Merged

Conversation

nazarepiedady
Copy link
Contributor

I am applying a subtle typo correction to the breaking-changes/default-export.md document in this pull request.
I found this typo while translating this document for the translated version of the website I am working on.

@nex3

@netlify
Copy link

netlify bot commented Aug 6, 2023

Deploy Preview for sass-lang ready!

Name Link
🔨 Latest commit fadf81b
🔍 Latest deploy log https://app.netlify.com/sites/sass-lang/deploys/64eeab94aca368000897362e
😎 Deploy Preview https://deploy-preview-792--sass-lang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nazarepiedady nazarepiedady changed the title fix(docs): correct default import example in default export breaking changes fix(docs): correct default import example about default export Aug 6, 2023
@nex3 nex3 self-requested a review August 7, 2023 20:42
@nazarepiedady
Copy link
Contributor Author

@nex3 is this issue already fixed?
Because I could close this pull request if so.

@nex3
Copy link
Contributor

nex3 commented Aug 18, 2023

I don't think this is fixed, but it does look like you need to rebase this onto the latest main branch.

@nazarepiedady
Copy link
Contributor Author

@nex3 the pull request is updated, I believe that now is possible to go ahead to the next stage.

@nex3
Copy link
Contributor

nex3 commented Aug 30, 2023

This still isn't rebased against the latest HEAD (you can tell because it has a bunch of duplicate commits listed, instead of just one small commit).

@nazarepiedady nazarepiedady force-pushed the fix-default-import-typo-in-default-export branch from 61571ed to fadf81b Compare August 30, 2023 02:38
@nazarepiedady
Copy link
Contributor Author

@nex3 I have no idea, and I cannot see a conflict until now. If it is not possible to do the merge, could you use the cherry-pick to only add to the main change I have made?

@nex3 nex3 requested review from Goodwine and removed request for nex3 September 5, 2023 20:20
@Goodwine Goodwine merged commit 983e0a5 into sass:main Sep 7, 2023
8 checks passed
asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024
)

* fix(docs): default import in `breaking-changes/default-export.md`

apply this change to correct a little typo in the default import
example that is in the last paragraph.
asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024
)

* fix(docs): default import in `breaking-changes/default-export.md`

apply this change to correct a little typo in the default import
example that is in the last paragraph.
@nazarepiedady nazarepiedady deleted the fix-default-import-typo-in-default-export branch July 10, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants