Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compound selector children output order #1529

Closed

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented May 1, 2020

While fixing sass/libsass#3084 I came across these.

@mgreter mgreter requested a review from nex3 May 1, 2020 11:53
@mgreter
Copy link
Contributor Author

mgreter commented May 1, 2020

Minimal reproduction case:

:before {
    &.red-icon {
        foo: bar;
    }
}

@nex3
Copy link
Contributor

nex3 commented May 2, 2020

What do these spec changes have to do with sass/libsass#3084 or with your reproduction case? None of them involve pseudo-elements like :before, and all of them look wrong to me—they're rearranging compound selectors to be in a different order than the user originally wrote them.

@mgreter
Copy link
Contributor Author

mgreter commented May 2, 2020

IMHO we should either throw an error or reorder invalid selectors provided by users (a warning in that case may also be useful), but when we do parentization we should probably always generate valid css.

@nex3
Copy link
Contributor

nex3 commented May 13, 2020

To keep things in one place I'm going to follow up on this at sass/dart-sass#996.

@nex3 nex3 closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants