Add specs covering CSS imports with layer conditions #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This focuses more generally on testing the limits of unknown identifiers and functions, rather than "layer" specifically.
stof
commented
May 19, 2022
| <===> | ||
| ================================================================================ | ||
| <===> media/list/after_feature/input.scss | ||
| @import "a" (b: c), (d: e) and (f: g), h; |
There was a problem hiding this comment.
this looks wrong to me. The , separates several ImportArgument, and (d: e) is not a valid ImportUrl
There was a problem hiding this comment.
This is valid CSS! An @import may be followed by a <media-query-list>, and (b: c), (d: e) and (f: g), h is a valid <media-query-list>.
There was a problem hiding this comment.
The the spec is ambiguous when allowing multiple ImportArgument
jathak
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#3285
skip dart-sass