Add specs for passing non-deg units to hwb's hue #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goodwine
reviewed
Jul 19, 2022
| Soon, it will instead be correctly converted to 57.2957795131deg. | ||
|
|
||
| To preserve current behavior: $hue * 1deg/1rad | ||
| To migrate to new behavior: 0deg + $hue |
There was a problem hiding this comment.
Does 0dev + $hue mean that users will have to always do this until dart-sass 2.0.0?
I wonder if we should give another alternative like doing the calculation to deg and saying
To migrate to new behavior, either:
- force-cast to deg units with: 0deg + $hue
- manually update to deg units: 57.3 deg
There was a problem hiding this comment.
Once we release Phase 2 non-deg angles will be automatically converted to degrees. 0deg + $hue is just a stop-gap measure to force the conversion before Phase 2 is released.
I'm always wary about suggesting literal values in these, because I expect a lot of the time the argument comes from something that is itself dynamic and so can't be reliably replaced by a single value.
Goodwine
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1607
[skip dart-sass]