Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hrx linter no longer validates or breaks down HRX where the root is a unit test #1824

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

Goodwine
Copy link
Member

recombines all existing directory unit tests into HRX files reverting files breaking up on #1817

Fixes #1821

@Goodwine Goodwine force-pushed the hrx-500 branch 3 times, most recently from ef9010b to e3ddaa2 Compare September 15, 2022 00:48
reverted files split for having over 500 lines if they were long
unit-test directories
@Goodwine Goodwine merged commit 3f1333f into main Sep 15, 2022
@Goodwine Goodwine deleted the hrx-500 branch September 15, 2022 01:29
@stof
Copy link
Contributor

stof commented Sep 15, 2022

This PR does not seem to recombine directories that were broken up in the previous PR

@Goodwine
Copy link
Member Author

The way I generated this PR:

git checkout main
git pull
git checkout -b hrx-500
git rebase --onto ${PR_SHA}~1 $PR_SHA hrx-500 #basically remove PR_SHA
git checkout main -- package.json tsconfig.json lint-spec.ts lib-js/lint-reporter.ts
# then changes to lint-spec.ts
_changesAfterPR=$(git diff $PR_SHA main)
_newChanges=$(git diff ${PR_SHA}~1 hrx-500)
diff <(echo "$_changesAfterPR") <(echo "$_newChanges")> # only diff was lint-spec.ts
npm run lint-spec -- --fix
git rebase main --interactive # and squashed any commits in between

Is there a particular directory that should not have been split? (the only non-splittable directory should have been HRX file that contains at most 1 unit test)

@stof
Copy link
Contributor

stof commented Sep 16, 2022

Look for input.scss files in that repo. Most of them should be unsplit.
And the fact that the unsplitting is not done is easy to see: the diff of this PR does not include any modified spec files.

git rebase main --interactive # and squashed any commits in between

This might have been the issue: it would have kept the split already done in main in between (as those files would not be modified in your branch).

@stof
Copy link
Contributor

stof commented Sep 17, 2022

I did the recombination work manually in #1827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spec linter should allow large HRX files if they are test units
3 participants