Test for fix of parent selector with a multiline rule #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciej-ka
added a commit
to maciej-ka/sass
that referenced
this pull request
Sep 28, 2016
Fixes newline placement when the parent selector is used with a
multiline rule.
```scss
.foo,
.bar {
.baz & {
color: red;
}
}
```
Before
```css
.baz .foo, .baz
.bar {
color: red; }
```
After
```css
.baz .foo,
.baz .bar {
color: red; }
```
Closes: sass#1976
Tests: sass/sass-spec#933
maciej-ka
changed the title
maciej-ka
added a commit
to maciej-ka/sass
that referenced
this pull request
Dec 18, 2016
Fixes newline placement when the parent selector is used with a
multiline rule.
```scss
.foo,
.bar {
.baz & {
color: red;
}
}
```
Before
```css
.baz .foo, .baz
.bar {
color: red; }
```
After
```css
.baz .foo,
.baz .bar {
color: red; }
```
Closes: sass#1976
Tests: sass/sass-spec#933
maciej-ka
force-pushed
the
fix-parent-with-newline
branch
from
bf71fed
to
7794b8b
Compare
It was written for nested output, but we use expanded by default now.
nex3
pushed a commit
to sass/sass
that referenced
this pull request
Dec 29, 2016
Fixes newline placement when the parent selector is used with a
multiline rule.
```scss
.foo,
.bar {
.baz & {
color: red;
}
}
```
Before
```css
.baz .foo, .baz
.bar {
color: red; }
```
After
```css
.baz .foo,
.baz .bar {
color: red; }
```
Closes: #1976
Tests: sass/sass-spec#933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to sass/sass#1976