Skip to content

Commit

Permalink
Implement access tracking for containingUrl (#3835)
Browse files Browse the repository at this point in the history
  • Loading branch information
ntkme committed Apr 17, 2024
1 parent b7a34b2 commit 92c48d2
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 1 deletion.
5 changes: 5 additions & 0 deletions EMBEDDED_PROTOCOL_CHANGELOG.md
@@ -1,3 +1,8 @@
## 2.7.0

* Add `containing_url_unused` field to `CanonicalizeResponse` and
`FileImportResponse`.

## 2.6.0

* Add `fatal_deprecation`, `silence_deprecation`, and `future_deprecation`
Expand Down
2 changes: 1 addition & 1 deletion spec/EMBEDDED_PROTOCOL_VERSION
@@ -1 +1 @@
2.6.0
2.7.0
18 changes: 18 additions & 0 deletions spec/embedded_sass.proto
Expand Up @@ -192,6 +192,15 @@ message InboundMessage {
// `null` instead.
string error = 3;
}

// Whether `containing_url` in `CanonicalizeRequest` is unused.
//
// The compiler can cache the `CanonicalizeResponse` if the `containing_url`
// is unused.
//
// The default value is `false`, thus when the value is not set by the host,
// the `CanonicalizeResponse` will not be cached by the compiler.
bool containing_url_unused = 4;
}

// A response indicating the result of importing a canonical URL.
Expand Down Expand Up @@ -257,6 +266,15 @@ message InboundMessage {
// An error message explaining why the URL could not be loaded.
string error = 3;
}

// Whether `containing_url` in `FileImportRequest` is unused.
//
// The compiler can cache the `FileImportResponse` if the `containing_url`
// is unused.
//
// The default value is `false`, thus when the value is not set by the host,
// the `FileImportResponse` will not be cached by the compiler.
bool containing_url_unused = 4;
}

// A response indicating the result of calling a custom Sass function defined
Expand Down

0 comments on commit 92c48d2

Please sign in to comment.