Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

str-index should return null for a non-existent element rather than 0 #1060

Closed
mirisuzanne opened this issue Jan 4, 2014 · 2 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@mirisuzanne
Copy link
Contributor

Shouldn't both be false?

// input
.test {
  index: index(one two three, four);
  str-index: str-index('one two three', 'four');
}

// output
.test {
  index: false;
  str-index: 0;
}
@nex3
Copy link
Contributor

nex3 commented Jan 7, 2014

Really it should return null, as per #832. I'll edit the issue title to reflect that.

It's a good thing you found this before 3.3 was released; it would be really hard to change this behavior later without breaking a bunch of people.

@xzyfer
Copy link

xzyfer commented Jan 14, 2014

Just ran into this myself 👍

@nex3 nex3 closed this as completed Jan 22, 2014
xzyfer added a commit to asimov/asimov-core that referenced this issue Nov 4, 2014
Addresses a TODO item that was blocked on a Sass bug
sass/sass#1060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants