Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New @keyframes parsing breaks keyframes mixins #1102

Closed
nex3 opened this issue Feb 5, 2014 · 0 comments
Closed

New @keyframes parsing breaks keyframes mixins #1102

nex3 opened this issue Feb 5, 2014 · 0 comments
Labels
bug Something isn't working
Milestone
3.3

Comments

@nex3
Copy link
Contributor

nex3 commented Feb 5, 2014

The new @keyframes parsing added by e6c60c4 restrict keyframes blocks from being parsed unless they're textually within a @keyframes rule. This breaks mixins like the following:

@include keyframes {
  10% { ... }
}

which is unacceptable.
nex3 added a commit that referenced this issue Feb 7, 2014
@nex3
Merge branch 'revert-keyframes'
035c51f 
The parsing changes to @Keyframes, while on the whole good, broke mixins that
included keyframes blocks. We'll figure out a better way to do this after 3.3.

See #946
Closes #1102
@nex3 nex3 closed this as completed Feb 7, 2014
@nex3 nex3 mentioned this issue Feb 7, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
1 participant
@nex3