@extend shouldn't fail if a selector fails to unify #2250
Labels
enhancement
New feature or request
Comments
nex3
added a commit
to sass/dart-sass
that referenced
this issue
Feb 25, 2017
This means that extensions that match but fail to unify are valid, but we think that's okay; see sass/sass#2250.
nex3
added a commit
to sass/dart-sass
that referenced
this issue
May 26, 2017
This means that extensions that match but fail to unify are valid, but we think that's okay; see sass/sass#2250.
nex3
added a commit
to sass/sass-spec
that referenced
this issue
May 28, 2017
nex3
added a commit
to sass/dart-sass
that referenced
this issue
May 28, 2017
This means that extensions that match but fail to unify are valid, but we think that's okay; see sass/sass#2250.
nex3
added a commit
to sass/dart-sass
that referenced
this issue
May 28, 2017
This means that extensions that match but fail to unify are valid, but we think that's okay; see sass/sass#2250.
nex3
added a commit
to sass/sass-spec
that referenced
this issue
May 28, 2017
nex3
added a commit
to sass/sass-spec
that referenced
this issue
Jun 16, 2017
nex3
added a commit
that referenced
this issue
Jun 16, 2017
nex3
added a commit
to sass/sass-spec
that referenced
this issue
Jun 16, 2017
nex3
added a commit
that referenced
this issue
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, a non-
!optional@extendwill produce an error if its target exists but fails to unify with its selector. This doesn't really fit with the original goal of the "missing target" error for@extend, which was to help catch typos, and it complicates implementation because it means that unused extends can't be detected by simple set operations on extend targets and simple selectors. We should eliminate this error, and allow@extends to silently do nothing if they match but unification fails.The text was updated successfully, but these errors were encountered: