New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@extend shouldn't fail if a selector fails to unify #2250

Closed
nex3 opened this Issue Feb 25, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@nex3
Contributor

nex3 commented Feb 25, 2017

Currently, a non-!optional @extend will produce an error if its target exists but fails to unify with its selector. This doesn't really fit with the original goal of the "missing target" error for @extend, which was to help catch typos, and it complicates implementation because it means that unused extends can't be detected by simple set operations on extend targets and simple selectors. We should eliminate this error, and allow @extends to silently do nothing if they match but unification fails.

nex3 added a commit to sass/dart-sass that referenced this issue Feb 25, 2017

Check extend usage after the fact.
This means that extensions that match but fail to unify are valid, but
we think that's okay; see sass/sass#2250.

nex3 added a commit to sass/dart-sass that referenced this issue May 26, 2017

Check extend usage after the fact.
This means that extensions that match but fail to unify are valid, but
we think that's okay; see sass/sass#2250.

nex3 added a commit to sass/sass-spec that referenced this issue May 28, 2017

nex3 added a commit to sass/dart-sass that referenced this issue May 28, 2017

Check extend usage after the fact.
This means that extensions that match but fail to unify are valid, but
we think that's okay; see sass/sass#2250.

nex3 added a commit to sass/dart-sass that referenced this issue May 28, 2017

Check extend usage after the fact.
This means that extensions that match but fail to unify are valid, but
we think that's okay; see sass/sass#2250.

nex3 added a commit to sass/sass-spec that referenced this issue May 28, 2017

nex3 added a commit to sass/sass-spec that referenced this issue Jun 16, 2017

nex3 added a commit that referenced this issue Jun 16, 2017

nex3 added a commit to sass/sass-spec that referenced this issue Jun 16, 2017

nex3 added a commit that referenced this issue Jun 16, 2017

@nex3 nex3 closed this Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment