Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bogus color warning? #2424

Closed
glebm opened this issue Dec 23, 2017 · 3 comments
Closed

Bogus color warning? #2424

glebm opened this issue Dec 23, 2017 · 3 comments

Comments

@glebm
Copy link

glebm commented Dec 23, 2017

Users have been reporting the following warning from Sass v3.5.2 and Sass v3.5.3

WARNING on line 4, column 7 of gems/bootstrap-4.0.0.beta2/assets/stylesheets/bootstrap/_root.scss:
You probably don't mean to use the color value `blue' in interpolation here.
It may end up represented as #0000ff, which will likely produce invalid CSS.
Always quote color names when using them as strings (for example, "blue").
If you really want to use the color value here, use `"" + $color'.
full log output for each `$color`

This is with regards to the following code:

https://github.com/twbs/bootstrap/blob/8b8999b07aecd0213ef0c984c6f8e104aef2c7f5/scss/_root.scss#L1-L5

However, these variable are quoted here:

https://github.com/twbs/bootstrap/blob/8b8999b07aecd0213ef0c984c6f8e104aef2c7f5/scss/_variables.scss#L49-L51

@nex3 Is this a buggy warning or are we doing something wrong? Thanks

@glebm
Copy link
Author

glebm commented Dec 23, 2017

Nevermind, user error.

@glebm glebm closed this as completed Dec 23, 2017
@jdavidbakr
Copy link

jdavidbakr commented Mar 26, 2019

@glebm - I just started getting this warning (updated to Laravel Mix version 4) and it looks to me like it's a problem with bootstrap's sass - which is what you are linking to. What did you end up figuring out what the issue was?

@jdavidbakr
Copy link

Found it - my issue was from this thread: twbs/bootstrap-rubygem#130 - apparently the older version of Laravel Mix was using a different sass processor that didn't fire this warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants