New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
color warning in _root.scss on heroku deploy #130
Comments
🔔 @glebm Is the fix useful? |
m5o
added a commit
to m5o/bootstrap
that referenced
this issue
Dec 17, 2017
* fix from twbs#24549 (comment) ``` WARNING on line 4, column 7 of gems/bootstrap-4.0.0.beta2/assets/stylesheets/bootstrap/_root.scss: You probably don't mean to use the color value `blue' in interpolation here. It may end up represented as #0000ff, which will likely produce invalid CSS. Always quote color names when using them as strings (for example, "blue"). If you really want to use the color value here, use `"" + $color'. ``` :link: twbs/bootstrap-rubygem#130
@m5o Does this warning also happen on Sass v3.5.4? |
Couldn't get it reproduced with In a different project of mine, it's still present… ok found the issue. -$colors: () !default;
-$colors: map-merge((
- blue: $blue,
- indigo: $indigo,
- purple: $purple,
- pink: $pink,
- red: $red,
[…]
+$colors: () !default;
+$colors: map-merge((
+ "blue": $blue,
+ "indigo": $indigo,
+ "purple": $purple,
+ "pink": $pink,
[…] Sorry, my mistake! Problem solved ☑️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
scss/_root.scss is generate this warning for each iteration of
$colors
.Example from a heroku deploy output.
Reference
🔗 twbs/bootstrap#24354
🔗 twbs/bootstrap#24549 (comment) – possible fix
The text was updated successfully, but these errors were encountered: