New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve unit strictness for function parameters #3374
Comments
Expanding this to cover functions beyond just colors—for example, |
I'm expanding this again to support passing |
Since this involves a relatively small breaking change, I'll give it a month for public comment. |
This has had more than enough time to sit, so I'm going to get started on it. |
This merges the color-units and random-with-units deprecation pages into a single shared function-units page, updates the color-units deprecations to reflect that Phase 2 has been enacted, and adds new function unit deprecations. See #511 See sass/sass#2904 See #662 See sass/sass#3374
This merges the color-units and random-with-units deprecation pages into a single shared function-units page, updates the color-units deprecations to reflect that Phase 2 has been enacted, and adds new function unit deprecations. See #511 See sass/sass#2904 See #662 See sass/sass#3374
This merges the color-units and random-with-units deprecation pages into a single shared function-units page, updates the color-units deprecations to reflect that Phase 2 has been enacted, and adds new function unit deprecations. See #511 See sass/sass#2904 See #662 See sass/sass#3374
This is now waiting on Dart Sass 2.0.0 |
This merges the color-units and random-with-units deprecation pages into a single shared function-units page, updates the color-units deprecations to reflect that Phase 2 has been enacted, and adds new function unit deprecations. See sass#511 See sass/sass#2904 See sass#662 See sass/sass#3374
This merges the color-units and random-with-units deprecation pages into a single shared function-units page, updates the color-units deprecations to reflect that Phase 2 has been enacted, and adds new function unit deprecations. See sass#511 See sass/sass#2904 See sass#662 See sass/sass#3374
Deprecation
Removal
Currently, many notionally-unitless parameters to various color-manipulation functions isn't checked for units. This doesn't match our general desire to enforce units more strictly, and it can cause confusing messages like sass/dart-sass#1745. We should deprecate this and require the numbers to be unitless in Dart Sass 2.0.0.
Note that
rgb
,hsl
, andhwb
explicitly allow %-based alpha colors for historical reasons, which we don't intend to deprecate.The text was updated successfully, but these errors were encountered: