[First-Class Calc] Fix a parenthesizing bug #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`a - (b - c)` and `a - (b + c)` should preserve the parentheses of the right-hand operand, but we weren't doing so. See #3147
nex3
added a commit
to sass/sass-spec
that referenced
this pull request
Sep 14, 2021
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Sep 14, 2021
Awjin
approved these changes
Sep 14, 2021
nex3
added a commit
to sass/sass-spec
that referenced
this pull request
Sep 14, 2021
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Sep 14, 2021
mirisuzanne
pushed a commit
that referenced
this pull request
Feb 10, 2022
`a - (b - c)` and `a - (b + c)` should preserve the parentheses of the right-hand operand, but we weren't doing so. See #3147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a - (b - c)should preserve the parentheses of the right-handoperand, but we weren't doing so.
See #3147