[JS Calculations] Add a proposal #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathak
approved these changes
Mar 24, 2023
stof
reviewed
Mar 27, 2023
| * - Let `calculation` be a calculation with name `"calc"` and a `argument` as | ||
| * its single argument. | ||
| * | ||
| * - Return the result of [simplifying] `calculation`. |
There was a problem hiding this comment.
Should we enforce that this returns a simplified calculation ? It would force to duplicate the simplification algorithm in all embedded hosts
| /** `internal`'s `right` field. */ | ||
| get right(): CalculationValue; | ||
|
|
||
| /** Whether `internal` is equal to `other.internal` in Sass. */ |
There was a problem hiding this comment.
the description looks weird to me, as there is no internal in this type definition.
There was a problem hiding this comment.
See
sass/spec/js-api/value/index.d.ts
Lines 32 to 34 in 32a7db8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.