[Hotfix Node Package Importer]- Handle subpath without extensions #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nex3 Let me know if there is more process (proposal, draft, etc) needed, or if this qualifies as a fast track fix. |
ntkme
reviewed
Feb 22, 2024
| @@ -554,8 +554,8 @@ potential subpaths, resolving for partials and file extensions. | |||
|
|
|||
| * Add `subpath` to `paths`. | |||
|
|
|||
| * Otherwise, add `subpath` + `.scss`, `subpath` + `.sass`, and `subpath` + | |||
| `.css` to `paths`. | |||
| * Otherwise, add `subpath`, `subpath` + `.scss`, `subpath` + `.sass`, and | |||
There was a problem hiding this comment.
I think we should make it explicit to only add the extensions when it's not specified. If it already has an extension (.scss, .sass, or .css), we should not try add another.
There was a problem hiding this comment.
This is cut off in this snippet, but the preceding lines contain an "if it has an extension", and this is the else.
* If `subpath` ends in `.scss`, `.sass`, or `.css`:
* Add `subpath` to `paths`.
* Otherwise...
nex3
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sass/dart-sass#2183
Adds
subpathto the list ofexport load paths.dart-sass- sass/dart-sass#2184
sass-spec- sass/sass-spec#1960