Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] avoid overwriting existing final gif #8

Closed
sassman opened this issue Oct 12, 2020 · 0 comments · Fixed by #9
Closed

[FEAT] avoid overwriting existing final gif #8

sassman opened this issue Oct 12, 2020 · 0 comments · Fixed by #9
Labels
Type: Enhancement New feature or request
Milestone
v0.1.2

Comments

@sassman
Copy link
Owner

sassman commented Oct 12, 2020

Given there is a file called t-rec.gif in $CWD
When generating a gif after a recording
Then the existing file is not overwritten
And a new file with a suffix _1 like t-rec_1.gif is added to the new gif
@sassman sassman added the Type: Enhancement New feature or request label Oct 12, 2020
@sassman sassman added this to the v0.1.2 milestone Oct 12, 2020
@sassman sassman changed the title [FEAT] avoid overwriting exiting final gif [FEAT] avoid overwriting existing final gif Oct 12, 2020
sassman added a commit that referenced this issue Oct 12, 2020
@sassman
feat(overwriting): #8 avoid owerwriting existing final gif
d2b89a5 
 - check if file `t-rec.gif` exisits in `$CWD` and generates suffixes until it does not more exists
 - like `t-rec_2.gif`
sassman added a commit that referenced this issue Oct 12, 2020
@sassman
feat(overwriting): #8 avoid overwriting existing final gif
fd8b315 
 - check if file `t-rec.gif` exisits in `$CWD` and generates suffixes until it does not more exists
 - like `t-rec_2.gif`
@sassman sassman linked a pull request Oct 12, 2020 that will close this issue
feat(overwriting): #8 avoid overwriting existing final gif #9
Merged
sassman added a commit that referenced this issue Oct 12, 2020
@sassman
feat(overwriting): #8 avoid overwriting existing final gif
a322bf8 
 - check if file `t-rec.gif` exisits in `$CWD` and generates suffixes until it does not more exists
 - like `t-rec_2.gif`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
v0.1.2
Development

Successfully merging a pull request may close this issue.

feat(overwriting): #8 avoid overwriting existing final gif sassman/t-rec-rs
1 participant
@sassman