-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter notebook created in University Edition appears off in github viewer #40
Comments
Ok, that code worked as expected for me. So what version of SAS, saspy and sas_kernel do you have? Where/how are you running? PC, linux? what access method? stdio, iom? What's your sascfg.py configuration you're using? Was this the only thing you submitted, or did you run other things before? did they work or not? did you change ODS settings in any code you already submitted? |
Hi Tom, Thanks for your help. I'll research and get back to you soon. Broadly it's just a jupyter notebook created with the latest updates as of yesterday on University Edition running in the latest stable virtualbox on Windows 10 64 bit. I Save The Notebook to a shared folder on my windows box and then uploaded it using the GitHub web form upload. So the most basic amateur way to possibly do it! |
Also it looks great from the notebook after it's generated. But it goes foul when viewed on GitHub with their renderer. |
Oh, I gotcha. Yes, I've seen that and never tracked it down. I don't need all that other info. This is something that is independent of any of that.
Here's where a community effort helps :)
Hint hint
I'll take a better look tomorrow, but, I know what you're talking about.
Thanks
Tom
On Jul 10, 2017 6:52 PM, Pappy Snore <notifications@github.com> wrote:
EXTERNAL
Also it looks great from the notebook after it's generated. But it goes foul when viewed on GitHub with their renderer.
-
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#40 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AQ48ZiS5apSt-_6tgnpneUWHS0pfdUKPks5sMqtCgaJpZM4OTUYK>.
|
Thanks Tom. I updated with simplified code too. |
I've reproduced this. I see that the html (at least the part for the table and cells) is the same between viewing it in jupyter and via github. Also, if I upload the downloaded one back into jupyter, it still reners correctly. I'll try to attach 2 snapshots that show it's the same html, but it's being interpreted differently by the two renderers. Don't know if those will be viewable, we'll see. |
Looks good on the Jupyter Notebook Viewer |
I contacted GitHub and sent them this thread, maybe they'll take a look. |
@snorehorse thanks! |
fantastic, thanks. I hadn't found time to try to do that yet. Thanks! |
This is fixed in Jupyter lab and with no way to fix in Jupyter Notebook I'm closing. |
Edit 20170710 - 10 PM Refreshed: This is my GitHub hosted Jupyter Notebook
The MSRP column contains HTML that doesn't belong, it skips every other observation, and the table loses its color formatting.
I tried changing the line endings to CR/LF instead of just LF, but this made no difference.
As displayed by the GitHub render (the table looks weird, this shows the issue):
What it should look like, as displayed by Jupyter editor window via University Edition:
The problem exists for both Chrome & Microsoft Edge, on Windows 10 64bit.
The text was updated successfully, but these errors were encountered: