Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter notebook created in University Edition appears off in github viewer #40

Closed
snorex opened this issue Jul 10, 2017 · 11 comments
Closed

Comments

@snorex
Copy link

snorex commented Jul 10, 2017

Edit 20170710 - 10 PM Refreshed: This is my GitHub hosted Jupyter Notebook

The MSRP column contains HTML that doesn't belong, it skips every other observation, and the table loses its color formatting.

I tried changing the line endings to CR/LF instead of just LF, but this made no difference.

As displayed by the GitHub render (the table looks weird, this shows the issue):

bad

What it should look like, as displayed by Jupyter editor window via University Edition:

good

The problem exists for both Chrome & Microsoft Edge, on Windows 10 64bit.

@tomweber-sas
Copy link
Contributor

Ok, that code worked as expected for me. So what version of SAS, saspy and sas_kernel do you have? Where/how are you running? PC, linux? what access method? stdio, iom? What's your sascfg.py configuration you're using? Was this the only thing you submitted, or did you run other things before? did they work or not? did you change ODS settings in any code you already submitted?
Note that I didn't ask you if it was plugged in :)

@snorex
Copy link
Author

snorex commented Jul 10, 2017

Hi Tom, Thanks for your help. I'll research and get back to you soon. Broadly it's just a jupyter notebook created with the latest updates as of yesterday on University Edition running in the latest stable virtualbox on Windows 10 64 bit. I Save The Notebook to a shared folder on my windows box and then uploaded it using the GitHub web form upload. So the most basic amateur way to possibly do it!

@snorex
Copy link
Author

snorex commented Jul 10, 2017

Also it looks great from the notebook after it's generated. But it goes foul when viewed on GitHub with their renderer.

@tomweber-sas
Copy link
Contributor

tomweber-sas commented Jul 10, 2017 via email

@snorex
Copy link
Author

snorex commented Jul 11, 2017

Thanks Tom. I updated with simplified code too.

@tomweber-sas
Copy link
Contributor

I've reproduced this. I see that the html (at least the part for the table and cells) is the same between viewing it in jupyter and via github. Also, if I upload the downloaded one back into jupyter, it still reners correctly. I'll try to attach 2 snapshots that show it's the same html, but it's being interpreted differently by the two renderers.

bad
good

Don't know if those will be viewable, we'll see.
I'm not really sure where to go from here. It appears to be the github viewer, but I'm not a UI guy, so I'm not sure if there's that can be done or not.

@snorex
Copy link
Author

snorex commented Jul 14, 2017

Looks good on the Jupyter Notebook Viewer
jbnotebook

@snorex
Copy link
Author

snorex commented Jul 14, 2017

I contacted GitHub and sent them this thread, maybe they'll take a look.

@jld23
Copy link
Contributor

jld23 commented Jul 14, 2017

@snorehorse thanks!

@tomweber-sas
Copy link
Contributor

fantastic, thanks. I hadn't found time to try to do that yet. Thanks!

@jld23
Copy link
Contributor

jld23 commented Mar 23, 2021

This is fixed in Jupyter lab and with no way to fix in Jupyter Notebook I'm closing.

@jld23 jld23 closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants