Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (IAC-397) Add password setting support for kibana new user logadm #263

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

riragh
Copy link
Member

@riragh riragh commented Jul 21, 2022

Changes:

viya4-monitoring-kubernetes added a new user 'logadm' as a day-to-day user for log monitoring for cluster administrators. Changes in this PR help user in setting password for this new user logadm.

To set the password for the logadm user, set the V4M_KIBANA_LOGADM_PASSWORD variable in ansible-vars file. If no password has been set for the logadm user, but a password has been set for the admin user (by using the V4M_KIBANA_PASSWORD variable), then that password is used for the logadm user also. If neither password has been set, random passwords are generated for these accounts. These random passwords are displayed in the log messages generated during the deployment process.

Tests:

Following scenarios were verified. See internal ticket for details.

  • Scenario 1: set password for logadm -- verify logadm can access dashboard with the set password
  • Scenario 2: Do not set password for logadm but set password for admin user -- verify logadm can access dashboard with the password set for admin user
  • Scenario 3: Do not set password for logadm and admin user -- verify password is randomly generated and output in the logs

@riragh riragh added the enhancement New feature or request label Jul 21, 2022
@riragh riragh self-assigned this Jul 21, 2022
@riragh riragh changed the title feat: Add password setting support for kibana new user logadm feat: (IAC-397) Add password setting support for kibana new user logadm Jul 21, 2022
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A questions and general comment. But looks good.

tags:
- install

- name: cluster-logging - output credentials
debug:
msg:
- "OpenSearch admin - username: admin, password: {{ V4M_KIBANA_PASSWORD }}"
- "OpenSearch admin - username: logadm, password: {{ V4M_KIBANA_LOGADM_PASSWORD }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing is off in the alignment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the spacing issue.

roles/monitoring/defaults/main.yaml Show resolved Hide resolved
docs/CONFIG-VARS.md Outdated Show resolved Hide resolved
Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@riragh riragh merged commit bb16541 into staging Jul 22, 2022
@riragh riragh deleted the iac-397 branch July 22, 2022 14:52
@riragh riragh mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants