Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (IAC-568) remove kibanaserver, logcollector and metricgetter id/passwords from "cluster-logging - output credentials" task #264

Merged
merged 1 commit into from
Jul 28, 2022
Merged

feat: (IAC-568) remove kibanaserver, logcollector and metricgetter id/passwords from "cluster-logging - output credentials" task #264

merged 1 commit into from
Jul 28, 2022

Conversation

riragh
Copy link
Member

@riragh riragh commented Jul 26, 2022

Change:

Removed the kibanaserver, logcollector and metricgetter credentials from "cluster-logging - output credentials" task

Test:

  • Ran 'cluster-logging, install' task, verified the above credentials were not present as part of output credentials task.
    See internal ticket for more details.

@riragh
feat: (IAC-568) remove kibanaserver, logcollector and metricgetter id…
dfe371d 
…/passwords from "cluster-logging - output credentials" task
@riragh riragh added the enhancement New feature or request label Jul 26, 2022
@riragh riragh requested a review from dhoucgitter July 26, 2022 18:49
@riragh riragh self-assigned this Jul 26, 2022
@riragh riragh changed the base branch from main to staging July 26, 2022 18:49
@riragh riragh requested a review from thpang July 26, 2022 18:50
dhoucgitter
dhoucgitter approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sayeun
sayeun approved these changes Jul 28, 2022
View reviewed changes
Copy link

@sayeun sayeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@riragh riragh merged commit b19da1e into staging Jul 28, 2022
@riragh riragh deleted the iac-568 branch July 28, 2022 15:19
thpang
thpang reviewed Jul 28, 2022
View reviewed changes
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riragh riragh mentioned this pull request Aug 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thpang thpang thpang left review comments

@dhoucgitter dhoucgitter dhoucgitter approved these changes

@sayeun sayeun sayeun approved these changes

Assignees

@riragh riragh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@riragh @dhoucgitter @sayeun @thpang