Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (IAC-645) Updated CAS transformer templates for CAS workers and backup #271

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

riragh
Copy link
Member

@riragh riragh commented Aug 3, 2022

Changes:

CAS transformers for workers and backup used for default CAS (provider's) are targeting "All" CASDeployments. For MT deployment, the values in the provider's CAS transformers overwrite the values for tenants' CAS during kustomization ignoring the user specified values for tenants' CAS.
The stale files cas-manage-workers.yaml and cas-manage-backup.yaml were updated to use latest CAS changes.

Tests:

Deployments were successful for all the scenarios with expected number of workers and backup controllers. See internal ticket for details.

  • Multi-tenant MPP deployment with 2 workers and backup controller -> Onboard ACME tenant with 1 worker and 0 backup controller
  • (Extended scenario1) Multi-tenant MPP deployment with 2 workers and 1 backup controller -> Onboard ACME tenant with 1 worker and 0 backup controller --> onboard another tenant INTECH with 0 worker and 1 backup controller
  • Multi-tenant MPP deployment with 2 workers and backup controller -> Onboard ACME tenant with 2 worker and 1 backup controller
  • Non Multi-tenant MPP deployment with 3 workers and 1 backup controller

@riragh riragh added the bug Something isn't working label Aug 3, 2022
@riragh riragh self-assigned this Aug 3, 2022
@riragh riragh marked this pull request as ready for review August 3, 2022 18:43
Copy link
Contributor

@jarpat jarpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@sayeun sayeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with Ritika about these changes. The contents are from the product team. Updated these files so that we are sync'ed with their latest and it works on MT and non-MT.

@riragh riragh merged commit 30b1776 into staging Aug 3, 2022
@riragh riragh deleted the mt_cas branch August 3, 2022 21:07
@riragh riragh mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants