Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (IAC-689) add new exclusion for storageclass patch transformer #287

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

dhoucgitter
Copy link
Member

@dhoucgitter dhoucgitter commented Aug 26, 2022

Why:

Release testready orders now include the du sas-data-agent-server-colocated
which does not have /spec/VolumeClaimTemplates in its StatefulSet
resulting in fatal kustomize error during DAC execution. Excluding that du
from the patchTransformer as we've done for two other dus earlier.

Why:

Release testready orders now include sas-data-agent-server-colocated
which does not have /spec/VolumeClaimTemplates in its StatefulSet
resulting in fatal kustomize error during DAC execution
@dhoucgitter dhoucgitter added the bug Something isn't working label Aug 26, 2022
@dhoucgitter dhoucgitter self-assigned this Aug 26, 2022
Copy link

@sayeun sayeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@riragh riragh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's the pattern. LGTM

@dhoucgitter dhoucgitter merged commit 784a92e into main Aug 26, 2022
@dhoucgitter dhoucgitter deleted the fix-main-iac-689 branch August 26, 2022 17:43
@riragh riragh mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants