Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (IAC-583): AKS add support for K8s 1.24 #254

Merged
merged 6 commits into from
Aug 26, 2022
Merged

feat: (IAC-583): AKS add support for K8s 1.24 #254

merged 6 commits into from
Aug 26, 2022

Conversation

riragh
Copy link
Member

@riragh riragh commented Aug 23, 2022

Background:

Starting from Kubernetes version 1.24.0 service account token is not automatically generated, thus it has to be created separately. The following resources were updated by the provider hashicorp/kubernetes to handle this change in v2.13.0: d/kubernetes_service_account, r/kubernetes_default_service_account, r/kubernetes_service_account. For Kubernetes clusters running v1.24+ default_secret_name will be empty. A warning message will be printed once any of the above resources are in use.

Changes:

  • To support 1.24+ Kubernetes version in AKS, secret is manually created for the service account
  • The default K8s value is updated from 1.22.6 to 1.23.8
  • Minor warning fix for provider hashicorp/azuread

Tests:

  1. Verified cluster creation with K8s version: 1.24.0 was successful. Viya deployment was successful and application was accessible
  2. Verified cluster was created successfully with the new default K8s version: 1.23.8. Viya deployment was successful and application was accessible
  3. Verified cluster creation with K8s version: 1.22.6 was successful. Viya deployment was successful and application was accessible
  4. Verified cluster creation with version 1.24.0 and create_static_kubeconfig=false was successful. Provider based kubeconfig was generated and used to deploy Viya successfully.

@riragh riragh added the enhancement New feature or request label Aug 23, 2022
modules/kubeconfig/main.tf Outdated Show resolved Hide resolved
modules/kubeconfig/main.tf Outdated Show resolved Hide resolved
modules/kubeconfig/main.tf Outdated Show resolved Hide resolved
modules/kubeconfig/main.tf Outdated Show resolved Hide resolved
@riragh riragh marked this pull request as ready for review August 23, 2022 22:45
modules/kubeconfig/main.tf Outdated Show resolved Hide resolved
modules/kubeconfig/main.tf Outdated Show resolved Hide resolved
@riragh riragh self-assigned this Aug 24, 2022
@riragh riragh marked this pull request as draft August 25, 2022 21:27
@riragh
Copy link
Member Author

riragh commented Aug 26, 2022

Updates made to unify the code across cloud providers. Verified cluster creation with both static kubeconfig and provider based kubeconfig. Changes ready for review.

@riragh riragh marked this pull request as ready for review August 26, 2022 14:09
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riragh riragh merged commit 254b4f3 into staging Aug 26, 2022
@riragh riragh deleted the iac-583 branch August 26, 2022 15:04
@riragh riragh mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants