-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (IAC-583): AKS add support for K8s 1.24 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpang
requested changes
Aug 23, 2022
thpang
requested changes
Aug 24, 2022
…e new resource kubernetes_secret
jarpat
approved these changes
Aug 24, 2022
thpang
reviewed
Aug 24, 2022
Updates made to unify the code across cloud providers. Verified cluster creation with both static kubeconfig and provider based kubeconfig. Changes ready for review. |
thpang
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
Starting from Kubernetes version
1.24.0
service account token is not automatically generated, thus it has to be created separately. The following resources were updated by the providerhashicorp/kubernetes
to handle this change inv2.13.0
:d/kubernetes_service_account
,r/kubernetes_default_service_account
,r/kubernetes_service_account
. For Kubernetes clusters running v1.24+default_secret_name
will be empty. A warning message will be printed once any of the above resources are in use.Changes:
hashicorp/azuread
Tests: