Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (IAC-1238) Resolve TFLint issue #348

Merged
merged 1 commit into from
Nov 27, 2023
Merged

chore: (IAC-1238) Resolve TFLint issue #348

merged 1 commit into from
Nov 27, 2023

Conversation

riragh
Copy link
Member

@riragh riragh commented Nov 22, 2023

Changes

Update the code to resolve terraform_deprecated_lookup linting issues

doc: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_lookup.md

Tests

Created infrastructure and ensured the sas-iac-buildinfo was present

$ kubectl get cm -n kube-system sas-iac-buildinfo -o yaml
apiVersion: v1
data:
  git-hash: 6471f1f2fc6edf1701a2d93fc2dc41d9073199d9
  iac-tooling: terraform
  terraform: |
    version: "1.4.5"
    revision: null
    provider-selections: {"registry.terraform.io/hashicorp/azuread":"2.39.0","registry.terraform.io/hashicorp/azurerm":"3.64.0","registry.terraform.io/hashicorp/cloudinit":"2.3.2","registry.terraform.io/hashicorp/external":"2.3.1","registry.terraform.io/hashicorp/kubernetes":"2.20.0","registry.terraform.io/hashicorp/local":"2.4.0","registry.terraform.io/hashicorp/null":"3.2.1","registry.terraform.io/hashicorp/tls":"4.0.4"}
    outdated: true
immutable: false
kind: ConfigMap
metadata:
  creationTimestamp: "2023-11-22T18:37:55Z"
  name: sas-iac-buildinfo
  namespace: kube-system
  resourceVersion: "1237"
  uid: b7c6670a-71cb-4755-a8a0-b56072bc638a

@riragh riragh added the enhancement New feature or request label Nov 22, 2023
@riragh riragh self-assigned this Nov 22, 2023
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riragh riragh merged commit 85d2bf6 into staging Nov 27, 2023
3 checks passed
@riragh riragh deleted the IAC-1238 branch November 27, 2023 20:34
@riragh riragh mentioned this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants