Skip to content

Commit

Permalink
Disable converting unimplemented rules, as sass-lint was breaking
Browse files Browse the repository at this point in the history
  • Loading branch information
@benthemonkey
benthemonkey committed Dec 16, 2015
1 parent eff1af4 commit 5b9c694
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 41 deletions.
80 changes: 40 additions & 40 deletions tests/rules.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1095,9 +1095,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': 1,
// 'attribute-name-format': 1,
'class-name-format': 1,
'element-name-format': 1,
// 'element-name-format': 1,
'id-name-format': 1,
'placeholder-name-format': 1
}
Expand All @@ -1110,9 +1110,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': [1, { 'allow-leading-underscore': true }],
// 'attribute-name-format': [1, { 'allow-leading-underscore': true }],
'class-name-format': [1, { 'allow-leading-underscore': true }],
'element-name-format': [1, { 'allow-leading-underscore': true }],
// 'element-name-format': [1, { 'allow-leading-underscore': true }],
'id-name-format': [1, { 'allow-leading-underscore': true }],
'placeholder-name-format': [1, { 'allow-leading-underscore': true }]
}
Expand All @@ -1125,9 +1125,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': [1, { 'allow-leading-underscore': false }],
// 'attribute-name-format': [1, { 'allow-leading-underscore': false }],
'class-name-format': [1, { 'allow-leading-underscore': false }],
'element-name-format': [1, { 'allow-leading-underscore': false }],
// 'element-name-format': [1, { 'allow-leading-underscore': false }],
'id-name-format': [1, { 'allow-leading-underscore': false }],
'placeholder-name-format': [1, { 'allow-leading-underscore': false }]
}
Expand All @@ -1140,9 +1140,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': [1, { 'ignore': ['foo'] }],
// 'attribute-name-format': [1, { 'ignore': ['foo'] }],
'class-name-format': [1, { 'ignore': ['foo'] }],
'element-name-format': [1, { 'ignore': ['foo'] }],
// 'element-name-format': [1, { 'ignore': ['foo'] }],
'id-name-format': [1, { 'ignore': ['foo'] }],
'placeholder-name-format': [1, { 'ignore': ['foo'] }]
}
Expand All @@ -1155,9 +1155,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': [1, { convention: 'snakecase' }],
// 'attribute-name-format': [1, { convention: 'snakecase' }],
'class-name-format': [1, { convention: 'snakecase' }],
'element-name-format': [1, { convention: 'snakecase' }],
// 'element-name-format': [1, { convention: 'snakecase' }],
'id-name-format': [1, { convention: 'snakecase' }],
'placeholder-name-format': [1, { convention: 'snakecase' }]
}
Expand All @@ -1170,9 +1170,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': [1, { convention: 'camelcase' }],
// 'attribute-name-format': [1, { convention: 'camelcase' }],
'class-name-format': [1, { convention: 'camelcase' }],
'element-name-format': [1, { convention: 'camelcase' }],
// 'element-name-format': [1, { convention: 'camelcase' }],
'id-name-format': [1, { convention: 'camelcase' }],
'placeholder-name-format': [1, { convention: 'camelcase' }]
}
Expand All @@ -1185,9 +1185,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': [1, { convention: 'strictbem' }],
// 'attribute-name-format': [1, { convention: 'strictbem' }],
'class-name-format': [1, { convention: 'strictbem' }],
'element-name-format': [1, { convention: 'strictbem' }],
// 'element-name-format': [1, { convention: 'strictbem' }],
'id-name-format': [1, { convention: 'strictbem' }],
'placeholder-name-format': [1, { convention: 'strictbem' }]
}
Expand All @@ -1200,9 +1200,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': [1, { convention: 'hyphenatedbem' }],
// 'attribute-name-format': [1, { convention: 'hyphenatedbem' }],
'class-name-format': [1, { convention: 'hyphenatedbem' }],
'element-name-format': [1, { convention: 'hyphenatedbem' }],
// 'element-name-format': [1, { convention: 'hyphenatedbem' }],
'id-name-format': [1, { convention: 'hyphenatedbem' }],
'placeholder-name-format': [1, { convention: 'hyphenatedbem' }]
}
Expand All @@ -1215,9 +1215,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': [1, { convention: 'foo' }],
// 'attribute-name-format': [1, { convention: 'foo' }],
'class-name-format': [1, { convention: 'foo' }],
'element-name-format': [1, { convention: 'foo' }],
// 'element-name-format': [1, { convention: 'foo' }],
'id-name-format': [1, { convention: 'foo' }],
'placeholder-name-format': [1, { convention: 'foo' }]
}
Expand All @@ -1230,9 +1230,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': [1, { 'convention-explanation': 'foo' }],
// 'attribute-name-format': [1, { 'convention-explanation': 'foo' }],
'class-name-format': [1, { 'convention-explanation': 'foo' }],
'element-name-format': [1, { 'convention-explanation': 'foo' }],
// 'element-name-format': [1, { 'convention-explanation': 'foo' }],
'id-name-format': [1, { 'convention-explanation': 'foo' }],
'placeholder-name-format': [1, { 'convention-explanation': 'foo' }]
}
Expand All @@ -1245,9 +1245,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': [1, { convention: 'snakecase' }],
// 'attribute-name-format': [1, { convention: 'snakecase' }],
'class-name-format': 1,
'element-name-format': 1,
// 'element-name-format': 1,
'id-name-format': 1,
'placeholder-name-format': 1
}
Expand All @@ -1260,9 +1260,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': 1,
// 'attribute-name-format': 1,
'class-name-format': [1, { convention: 'snakecase' }],
'element-name-format': 1,
// 'element-name-format': 1,
'id-name-format': 1,
'placeholder-name-format': 1
}
Expand All @@ -1275,9 +1275,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': 1,
// 'attribute-name-format': 1,
'class-name-format': 1,
'element-name-format': [1, { convention: 'snakecase' }],
// 'element-name-format': [1, { convention: 'snakecase' }],
'id-name-format': 1,
'placeholder-name-format': 1
}
Expand All @@ -1290,9 +1290,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': 1,
// 'attribute-name-format': 1,
'class-name-format': 1,
'element-name-format': 1,
// 'element-name-format': 1,
'id-name-format': [1, { convention: 'snakecase' }],
'placeholder-name-format': 1
}
Expand All @@ -1305,9 +1305,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': 1,
// 'attribute-name-format': 1,
'class-name-format': 1,
'element-name-format': 1,
// 'element-name-format': 1,
'id-name-format': 1,
'placeholder-name-format': [1, { convention: 'snakecase' }]
}
Expand All @@ -1320,9 +1320,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': [1, { 'convention-explanation': 'foo' }],
// 'attribute-name-format': [1, { 'convention-explanation': 'foo' }],
'class-name-format': 1,
'element-name-format': 1,
// 'element-name-format': 1,
'id-name-format': 1,
'placeholder-name-format': 1
}
Expand All @@ -1335,9 +1335,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': 1,
// 'attribute-name-format': 1,
'class-name-format': [1, { 'convention-explanation': 'foo' }],
'element-name-format': 1,
// 'element-name-format': 1,
'id-name-format': 1,
'placeholder-name-format': 1
}
Expand All @@ -1350,9 +1350,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': 1,
// 'attribute-name-format': 1,
'class-name-format': 1,
'element-name-format': [1, { 'convention-explanation': 'foo' }],
// 'element-name-format': [1, { 'convention-explanation': 'foo' }],
'id-name-format': 1,
'placeholder-name-format': 1
}
Expand All @@ -1365,9 +1365,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': 1,
// 'attribute-name-format': 1,
'class-name-format': 1,
'element-name-format': 1,
// 'element-name-format': 1,
'id-name-format': [1, { 'convention-explanation': 'foo' }],
'placeholder-name-format': 1
}
Expand All @@ -1380,9 +1380,9 @@ describe('Rule Conversion', function () {
}
}).rules,
{
'attribute-name-format': 1,
// 'attribute-name-format': 1,
'class-name-format': 1,
'element-name-format': 1,
// 'element-name-format': 1,
'id-name-format': 1,
'placeholder-name-format': [1, { 'convention-explanation': 'foo' }]
}
Expand Down
2 changes: 1 addition & 1 deletion translations.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ module.exports.SelectorFormat = {
special_case: function (linterValue, sassSettings, severity) {
var i, name, specificSettings,
generalSettings = {},
types = ['attribute', 'class', 'element', 'id', 'placeholder'],
types = ['class', 'id', 'placeholder'], // Missing: attribute, element
translateConvention = function (_convention) {
switch (_convention) {
case 'hyphenated_lowercase':
Expand Down

0 comments on commit 5b9c694

Please sign in to comment.