Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefixes array being passed between assertions (no-vendor-prefixes) #182

Closed
bgriffith opened this issue Sep 18, 2015 · 1 comment · Fixed by #183
Closed

Prefixes array being passed between assertions (no-vendor-prefixes) #182

bgriffith opened this issue Sep 18, 2015 · 1 comment · Fixed by #183
Labels
Milestone

Comments

@bgriffith
Copy link
Member

Currently the prefixes array in the no-vendor-prefixes is not getting reset between assertions. This means that if you modify the array through adding or removing prefixes in an assertion, these changes will still exist for the next assertion.

Was this intended @DanPurdy Only reason I ask is that the expected number of warnings is only true when this behaviour is allowed.

Easiest way to simulate is to create a new assertion with only the defaults.

SassLint: 1.2.0

@DanPurdy
Copy link
Member

Hence why there are so many test variations yes.. The only way really to stop this happening currently is to seperate out the tests, not ideal.. I don't think this is too much of a problem as it is, it's testing exactly what we want it to and every case is covered..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants