Sass Syntax - Tests progress

[bgriffith]

Having had a few Sass Syntax related issues popping up, I think it would be a good move to create tests for that syntax too.

I've started going through the current tests and have created quite a few .sass equivalents. So far there has been a few tests that have failed but the majority are ok.

By testing both the SCSS and Sass syntax I feel we will then be able to confidently say that we have cross syntax support.

I'll update the list below as I go.

The rules

• border-zero
• clean-import-paths - (Issue Sass Syntax - Clean import paths issues #179, Fixed Hotfix master - Fix Sass syntax issue with clean-import-paths rule #205)
• empty-args
• empty-line-between-blocks - (:bug: Issue Sass Syntax - empty-line-between-blocks rule not working #216)
• extends-before-declarations
• extends-before-mixins - (Fixed issue Hotfix master - Fix Sass extends-before-mixins bug #203)
• final-newline - (Issue Sass Syntax - final-newline not working correctly #207, Fixed Hotfix master - Fix Sass Syntax issue with final-newline rules #208)
• hex-length
• hex-notation
• indentation
• leading-zero
• mixing-before-declarations
• nesting-depth
• no-color-keywords
• no-color-literals (Issue no-color-literals rule mutating a value - effecting assertions that follow #186, Fixed in Feature/reset defaults on new assertion color literals #187)
• no-css-comments
• no-debug
• no-duplicate-properties
• no-extends - (Fixed issue - No extends not working with Sass Syntax #173)
• no-ids
• no-important
• no-invalid-hex
• no-qualifying-elements
• no-trailing-zeros
• no-url-protocols
• no-vendor-prefix (Issue Prefixes array being passed between assertions (no-vendor-prefixes) #182, Fixed in Fix issue of non-reseting prefixes #183)
• no-warn
• placeholder-in-extend - (Fixed in Hotfix master - Fix Sass syntax issue with placeholder-in-extend rule #204)
• property-sort-order
• quotes
• shorthand values
• single-line-per-selector - (Fixed issue - TypeError: Cannot read property 'line' of undefined #165)
• space-after-bang
• space-after-colon
• space-after-comma
• space-before bang
• space-before-colon
• space-before-parens
• url-quotes
• variable-for-property
• zero-unit

Rules that are N/A

• trailing-semicolon
• space-before-brace
• no-empty-rulesets
• brace-style
• one-declaration-per-line

[DanPurdy]

Awesome, I started having a look at this after we spoke this morning, but looks like you've got further ahead than me. Do you wanna explain a little how you're going about it, I've got a few rules nearly done here that i'd like to get the sass tests up and running for too, be good to have them in the same format as yours.

[bgriffith]

Sure, it's very simple and happy to alter if you've got a better suggestion.

All I'm doing is creating .sass versions of the .scss files (with any adjustments if required) and updating the mocha test file to test for both.

Ideally we should be writing the actual rules in a way that's syntax agnostic so in my mind we shouldn't have two separate tests but simply improve the current one's to take into account any issues (currently not too many).

Example below;

'use strict';

var lint = require('./_lint');

describe('no extends - scss', function () {
  var file = lint.file('no-extends.scss');

  it('scss - enforce', function (done) {
    lint.test(file, {
      'no-extends': 1
    }, function (data) {
      lint.assert.equal(1, data.warningCount);
      done();
    });
  });
});

describe('no extends - sass', function () {
  var file = lint.file('no-extends.sass');

  it('sass - enforce', function (done) {
    lint.test(file, {
      'no-extends': 1
    }, function (data) {
      lint.assert.equal(1, data.warningCount);
      done();
    });
  });
});

The only issue I've found with this method is that you have declare file within the assertion and so there's some duplication of that when you have lots of assertions. Thoughts?

[DanPurdy]

This will be ok to start with but I think the duplication will become a little unmanageable for the rules where there are lots of test cases.

The tests should give the same results for both scss and sass, but I guess seen as some of the rules won't apply to the sass side of things it adds a small challenge there, for now something as simple as setting the file variable to an array of the 2 different syntaxes and then just looping the tests could work for now?

i.e. one loop for the whole test sweet that just runs each tests against each syntax

[DanPurdy]

Followed your lead I believe for this new rule, we can revisit once everything is up and running again?

[DanPurdy]

You should look to get this up as a PR soon preferably before you go any further, we can then keep track a bit better of what still needs to be done and any issues we find in separate issues. Also it'll give us a nice base from which to get sass tests as the norm for any further rules being written.

[DanPurdy]

Going to wait for the latest version of gonzales-pe to rewrite the indentation. Moving this out of 1.4.0 for now.

[bgriffith]

Indentation is now good.