Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixins-before-declarations should not raise warning with top-level mixins #227

Closed
BPScott opened this issue Sep 28, 2015 · 1 comment
Closed
Labels
Milestone

Comments

@BPScott
Copy link

BPScott commented Sep 28, 2015

Currently @includeing a mixin at the top level (i.e. not inside a selector) incorrectly raises a 'mixins-before-delcarations' warning, when this should be acceptable (there are no properties before it!).

To reproduce, add the following to the bottom of mixins-before-declarations.scss:

@include hello;

@media (min-width: 50em) {
  @include hello;
}

@supports (display: flex) {
  @include hello;
}

@at-root {
  @include hello;
}

I would expect that this would raise no additional linting errors.

@BPScott BPScott changed the title mixins-before-declarations should not error with top-level mixins mixins-before-declarations should not raise warning with top-level mixins Sep 28, 2015
@DanPurdy DanPurdy added the bug label Sep 28, 2015
@DanPurdy DanPurdy added this to the 1.2.3 milestone Sep 28, 2015
@shaneog
Copy link

shaneog commented Sep 30, 2015

👍

@DanPurdy DanPurdy modified the milestones: 1.2.4, 1.2.3 Oct 5, 2015
donabrams pushed a commit to donabrams/sass-lint that referenced this issue Nov 19, 2015
Add check for declaration node content type
Fixes sasstools#227
Fixes sasstools#230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants