Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic placeholders causes a fatal error #532

Closed
ngryman opened this issue Feb 16, 2016 · 4 comments
Closed

Dynamic placeholders causes a fatal error #532

ngryman opened this issue Feb 16, 2016 · 4 comments

Comments

@ngryman
Copy link
Contributor

ngryman commented Feb 16, 2016

Hi,

Dynamic placeholder names are reported as fatal errors when declared but not when they are extended.
I'm using sass-lint 1.5.0.

Code example:

// produces an error
%#{$placeholder-id} { color: red; }
// but the following is ok
'%#{$placeholder-id}' { color: red; }

// this does not produce an error
@extend %#{$placeholder-id};
@DanPurdy
Copy link
Member

This is a problem with the version of gonzales-pe (our AST) we were using. It didn't have great support for interpolation.

I can confirm that all your above examples work in the latest version of gonzales-pe which we're currently in the process of upgrading to. It should be complete and released shortly.

See #495

@ngryman
Copy link
Contributor Author

ngryman commented Feb 16, 2016

@DanPurdy Awesome, thanks for the quick reply!

@IlanFrumer
Copy link

+1

@bgriffith
Copy link
Member

@ngryman Fixed in 1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants