-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic task: Fixing rules to work with the latest version of Gonzales-pe #495
Comments
I'll do all the rules I made. So *-name-format rules and collectSuffixExtensions |
Could you list them quickly? So I can assigned them? 👍 |
|
Nice stuff guys. If you don't mind I would like to help. For the beginning I thought about something easy and fix Is that okay? |
Please go ahead! |
Put me down for |
Done! |
I have a look at |
Almost there! |
I'll get round to no mergeable selectors this weekend |
Or this week... 😄 |
It looks like mergeable selectors is done. As are all the tasks listed above. Is this issue completed? If not, what tasks need help? (If it is completed, woo-hoo!) |
It is all done and more besides, we've just had to take a bit of extra time to investigate some windows related issues with the AST which has delayed us slightly, I keep saying this but hopefully very soon! |
Closing as 1.6.0 is released! 🎉 |
Keen to upgrade to the latest version of gonzales with the hope that it will help solve many issues popping up.
Since there was a big change between the version we use now and gonzales v3.2.1, a lot of the tests are failing.
We've created a branch on here (
feature/gonzales-3-develop
) which will have any test fixes PR'd into it.If anyone would like to help out and fix a rule please let me know in here so that we can assign you and so that we don't waste time working on the same issue.
Once a fix has been merged, I'll update the list.
Broken rules
helpers [assigned: benthemonkey]
bem depth - scss [assigned: benthemonkey]
bem depth - sass [assigned: benthemonkey]
brace style - sass [assigned: bgriffith]
class name format - scss [assigned: benthemonkey]
class name format - sass [assigned: benthemonkey]
empty line between blocks - sass
extends before declarations - scss [assigned: bgriffith]
extends before declarations - sass [assigned: bgriffith]
extends before mixins - sass [assigned: bgriffith]
force attribute nesting - scss [assigned: danpurdy]
force attribute nesting - sass [assigned: danpurdy]
force element nesting - scss [assigned: danpurdy]
force element nesting - sass [assigned: danpurdy]
force pseudo nesting - scss [assigned: danpurdy]
force pseudo nesting - sass [assigned: danpurdy]
id name format - scss [assigned: benthemonkey]
id name format - sass [assigned: benthemonkey]
indentation - scss
mixin name format - scss [assigned: benthemonkey]
mixin name format - sass [assigned: benthemonkey]
mixins before declarations - scss [assigned: danpurdy]
mixins before declarations - sass [assigned: danpurdy]
nesting depth - scss
nesting depth - sass
no mergeable selectors - scss [assigned: danpurdy]
no mergeable selectors - sass [assigned: danpurdy]
no qualifying elements - scss [assigned: bgriffith]
no qualifying elements - sass [assigned: bgriffith]
placeholder in extend - sass [assigned: bgriffith]
placeholder in extend - sass [assigned: bgriffith]
single line per selector - scss [assigned: bgriffith]
single line per selector - sass [assigned: bgriffith]
space after bang - sass [assigned: bgriffith]
space after bang - sass [assigned: bgriffith]
space after comma - sass [assigned: bgriffith]
space around operator - scss [assigned: bgriffith]
space around operator - sass [assigned: bgriffith]
space before brace - scss [assigned: danez]
The text was updated successfully, but these errors were encountered: