Epic task: Fixing rules to work with the latest version of Gonzales-pe

[bgriffith]

Keen to upgrade to the latest version of gonzales with the hope that it will help solve many issues popping up.

Since there was a big change between the version we use now and gonzales v3.2.1, a lot of the tests are failing.

We've created a branch on here (feature/gonzales-3-develop) which will have any test fixes PR'd into it.

If anyone would like to help out and fix a rule please let me know in here so that we can assign you and so that we don't waste time working on the same issue.

Once a fix has been merged, I'll update the list.

Broken rules

helpers [assigned: benthemonkey]

• collectSuffixExtensions - no extensions
• collectSuffixExtensions - BEM example
• collectSuffixExtensions - many parents and children

bem depth - scss [assigned: benthemonkey]

• [max-depth: 0]
• [max-depth: 1]

bem depth - sass [assigned: benthemonkey]

• [max-depth: 0]
• [max-depth: 1]

brace style - sass [assigned: bgriffith]

• [style: 1tbs, allow-single-line: true]
• [style: 1tbs, allow-single-line: false]
• [style: stroustrup, allow-single-line: true]
• [style: stroustrup, allow-single-line: false]
• [style: allman, allow-single-line: true]
• [style: allman, allow-single-line: false]

class name format - scss [assigned: benthemonkey]

• [convention: hyphenatedlowercase]
• [convention: hyphenatedlowercase with ignore]
• [convention: camelcase]
• [convention: snakecase]
• [convention: strictbem]
• [convention: hyphenatedbem]
• [convention: RegExp ^[_A-Z]+$]
• [convention: RegExp ^[_A-Z]+$], with convention-explanation

class name format - sass [assigned: benthemonkey]

• [convention: hyphenatedlowercase]
• [convention: hyphenatedlowercase with ignore]
• [convention: camelcase]
• [convention: snakecase]
• [convention: strictbem]
• [convention: hyphenatedbem]
• [convention: RegExp ^[_A-Z]+$]
• [convention: RegExp ^[_A-Z]+$], with convention-explanation

empty line between blocks - sass

• without comments - [include: true, allow-single-line-rulesets: true]
• without comments - [include: true, allow-single-line-rulesets: false]

extends before declarations - scss [assigned: bgriffith]

• enforce

extends before declarations - sass [assigned: bgriffith]

• enforce

extends before mixins - sass [assigned: bgriffith]

• enforce

force attribute nesting - scss [assigned: danpurdy]

• [default]

force attribute nesting - sass [assigned: danpurdy]

• [default]

force element nesting - scss [assigned: danpurdy]

• [default]

force element nesting - sass [assigned: danpurdy]

• [default]

force pseudo nesting - scss [assigned: danpurdy]

• [default]

force pseudo nesting - sass [assigned: danpurdy]

• [default]

id name format - scss [assigned: benthemonkey]

• [convention: hyphenatedlowercase]
• [convention: hyphenatedlowercase with ignore]
• [convention: camelcase]
• [convention: snakecase]
• [convention: RegExp ^[_A-Z]+$]
• [convention: RegExp ^[_A-Z]+$], with convention-explanation

id name format - sass [assigned: benthemonkey]

• [convention: hyphenatedlowercase]
• [convention: hyphenatedlowercase with ignore]
• [convention: camelcase]
• [convention: snakecase]
• [convention: RegExp ^[_A-Z]+$]
• [convention: RegExp ^[_A-Z]+$], with convention-explanation

indentation - scss

• [size: 2]

mixin name format - scss [assigned: benthemonkey]

• [convention: hyphenatedlowercase]
• [convention: camelcase]
• [convention: RegExp ^[_A-Z]+$]
• [convention: allow-leading-underscore false]

mixin name format - sass [assigned: benthemonkey]

• [convention: hyphenatedlowercase]
• [convention: camelcase]
• [convention: RegExp ^[_A-Z]+$]
• [convention: allow-leading-underscore false]

mixins before declarations - scss [assigned: danpurdy]

• enforce
• [excludes: limited]

mixins before declarations - sass [assigned: danpurdy]

• enforce
• [excludes: limited]

nesting depth - scss

• [max-depth: 2]

nesting depth - sass

• [max-depth: 2]

no mergeable selectors - scss [assigned: danpurdy]

• [default]
• [whitelist: div p]

no mergeable selectors - sass [assigned: danpurdy]

• [default]
• [whitelist: div p]

no qualifying elements - scss [assigned: bgriffith]

• [attribute: false, class: false, id: false]
• [attribute: true, class: false, id: false]
• [attribute: false, class: true, id: false]
• [attribute: false, class: false, id: true]
• [attribute: true, class: true, id: false]

no qualifying elements - sass [assigned: bgriffith]

• [attribute: false, class: false, id: false]
• [attribute: true, class: false, id: false]
• [attribute: false, class: true, id: false]
• [attribute: false, class: false, id: true]
• [attribute: true, class: true, id: false]

placeholder in extend - sass [assigned: bgriffith]

• enforce

placeholder in extend - sass [assigned: bgriffith]

• enforce

single line per selector - scss [assigned: bgriffith]

• enforce

single line per selector - sass [assigned: bgriffith]

• enforce

space after bang - sass [assigned: bgriffith]

• [include: false]
• [include: true]

space after bang - sass [assigned: bgriffith]

• sass - [include: false]
• sass - [include: true]

space after comma - sass [assigned: bgriffith]

• [include: false]

space around operator - scss [assigned: bgriffith]

• [include: true]
• [include: false]

space around operator - sass [assigned: bgriffith]

• [include: true]
• [include: false]

space before brace - scss [assigned: danez]

• [include: true]
• [include: false]

[benthemonkey]

I'll do all the rules I made. So *-name-format rules and collectSuffixExtensions

[bgriffith]

Could you list them quickly? So I can assigned them? 👍

[benthemonkey]

collectSuffixExtensions, bem-depth, class-name-format, id-name-format, mixin-name-format

[danez]

Nice stuff guys. If you don't mind I would like to help. For the beginning I thought about something easy and fix space-before-brace and create a PR for it.

Is that okay?

[bgriffith]

Please go ahead!

[DanPurdy]

Put me down for no mergeable selectors, mixins before declarations, and the force element/attribute/pseudo ones

[bgriffith]

Done!

[danez]

I have a look at empty line between blocks, indentation and nesting depth for sass and scss

[bgriffith]

Almost there!

[DanPurdy]

I'll get round to no mergeable selectors this weekend

[DanPurdy]

Or this week... 😄

[JohnAlbin]

It looks like mergeable selectors is done. As are all the tasks listed above.

Is this issue completed? If not, what tasks need help? (If it is completed, woo-hoo!)

[DanPurdy]

It is all done and more besides, we've just had to take a bit of extra time to investigate some windows related issues with the AST which has delayed us slightly, I keep saying this but hopefully very soon!

[DanPurdy]

Closing as 1.6.0 is released! 🎉