Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: empty-line-between-blocks doesn't detect top level blocks #54

Closed
segovia94 opened this issue Aug 30, 2015 · 2 comments
Closed

Bug: empty-line-between-blocks doesn't detect top level blocks #54

segovia94 opened this issue Aug 30, 2015 · 2 comments
Assignees
Milestone

Comments

@segovia94
Copy link

I can't get any warning on top level selectors missing empty lines. Only selectors inside parent blocks are being detected.

// No warning thrown
.element {
  color: red;
}
.sibling {
  color: blue;
}
// This does correctly throw a warning
.block {

  .element {
    color: red;
  }
  .sibling {
    color: blue;
  }

}

I'm running it through the grunt plugin 0.1.0-beta.3 which is using sass-lint v1.0.0.

@segovia94 segovia94 changed the title empty-line-between-blocks doesn't detect top level blocks Bug: empty-line-between-blocks doesn't detect top level blocks Aug 30, 2015
@Snugug Snugug added this to the 1.0.1 milestone Aug 30, 2015
@Snugug Snugug added the bug label Aug 30, 2015
@segovia94
Copy link
Author

I just found in the docs that this is actually designed to only do nested blocks. Is there any reason we shouldn't also allow it to do top level blocks as well?

@Snugug Snugug self-assigned this Aug 31, 2015
@Snugug
Copy link
Member

Snugug commented Aug 31, 2015

Only cause it was written that way. I think it's fair that it should test all blocks

@Snugug Snugug closed this as completed in 5b90743 Aug 31, 2015
donabrams pushed a commit to donabrams/sass-lint that referenced this issue Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants