Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow usage of certain properties #546

Closed
alexeibs opened this issue Feb 25, 2016 · 2 comments · Fixed by #710
Closed

Disallow usage of certain properties #546

alexeibs opened this issue Feb 25, 2016 · 2 comments · Fixed by #710

Comments

@alexeibs
Copy link
Contributor

According to this
https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md#propertyspelling
scss-lint supports such a feature. There is a similar linter 'no-misspelled-properties' in sass-lint but its config can include only 'extra_properties'.
What do you think about extending functionality of 'no-misspelled-properties' to support 'disabled_properties' too? Source code of this linter looks pretty simple so creating a pull request wouldn't be difficult.

@DanPurdy
Copy link
Member

We favour small single purpose rules so we would probably prefer a completely separate rule for this as checking the spelling of a property and also disallowing properties is technically two different use cases. Something like no-disallowed-properties would be ok.

@Snugug
Copy link
Member

Snugug commented Feb 25, 2016

We prefer single targeted rules as much as possible, so we'd prefer a separate rule disallowing properties to an option on misspelled rules. That being said, I think that's fine, I'd be open to adding that rule.

On Feb 25, 2016, at 5:33 AM, Alexei Bykov notifications@github.com wrote:

According to this
https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md#propertyspelling
scss-lint supports such a feature. There is a similar linter 'no-misspelled-properties' in sass-lint but its config can include only 'extra_properties'.
What do you think about extending functionality of 'no-misspelled-properties' to support 'disabled_properties' too? Source code of this linter looks pretty simple so creating a pull request wouldn't be difficult.


Reply to this email directly or view it on GitHub.

alexeibs pushed a commit to alexeibs/sass-lint that referenced this issue Feb 27, 2016
alexeibs pushed a commit to alexeibs/sass-lint that referenced this issue Apr 7, 2016
DanPurdy pushed a commit to DanPurdy/sass-lint that referenced this issue May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants