Feature lint double semi colons #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgriffith
reviewed
Aug 26, 2017
lib/rules/trailing-semicolon.js
Outdated
| var hasDoubleSemiColon = function (tree) { | ||
|
|
||
| tree.traverseByType('declarationDelimiter', function (node, index, parent) { | ||
| if (parent.content[index + 1].is('declarationDelimiter')) { |
There was a problem hiding this comment.
Woud check that parent.content[index + 1] exists before calling is
|
Just noticed that this looks wrong though, 4 failure cases added but only increments the warning count by 3. |
DanPurdy
force-pushed
the
feature_lint-double-semi-colons
branch
from
5ca8e7b
to
09f4c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to update a contributors branch so just created a new quick PR here. Full credit to @JordanDDisch
see #863 for details
closes #863
Fixes #852