Allow functions & custom props in rgba params #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgriffith
reviewed
Sep 2, 2017
| funcType === 'rgba' && | ||
| valElem.content[1].content[0].type !== 'variable' && | ||
| funcType === 'rgba' && ( | ||
| valElem.content[1].content[0].type !== 'variable' && |
There was a problem hiding this comment.
Suggest we use !valElem.content[1].content[0].is('variable') etc
bgriffith
approved these changes
Sep 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions being passed as params of rgba were flaggins as literals. This change allows functions to be passed properly as params of rgba.
Fixes #853
There's a lot of other things mentioned in that ticket but I believe all the others to be either misconfigured rules or invalid configs. Happy to keep the issue open if we don't agree though.
<DCO 1.1 Signed-off-by: Dan Purdy dan@dpurdy.me>