Stop property-sort-order and no-value-vendor-prefix from throwing with css variables
#1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These cause the tests to throw.
If we want to see if Usage exists, it needs an indexOf !== -1, not > 0
justinanastos
changed the title
property-sort-order from throwing with css variablesproperty-sort-order and no-value-vendor-prefix from throwing with css variables
|
Please merge this ASAP. This is blocking me from integrating sass-lint on our workflow... |
|
I would also like this merged :) |
|
@justinanastos there is a merge conflict. @DanPurdy is there additional effort or comments to be made on this PR beyond the merge conflict? |
| @@ -1,4 +1,5 @@ | |||
| .foo | |||
| --css-variable: 100vh; | |||
There was a problem hiding this comment.
Suggested change
| --css-variable: 100vh; | |
| --css-variable: 100vh |
|
Is there anything holding this up from being merged other than the conflict? |
| @@ -99,8 +99,14 @@ module.exports = { | |||
|
|
|||
| if (block) { | |||
| block.forEach('declaration', function (dec) { | |||
| var prop = dec.first('property'), | |||
| name = prop.first('ident'); | |||
| var prop = dec.first('property'); | |||
There was a problem hiding this comment.
Suggested change
| var prop = dec.first('property'); | |
| var prop = dec.first('property') || dec.first('customProperty'); |
from #1207
| return; | ||
| } | ||
|
|
||
| var name = prop.first('ident'); |
There was a problem hiding this comment.
Suggested change
| var name = prop.first('ident'); | |
| var name; | |
| if (typeof(prop.first) === 'function') { | |
| name = prop.first('ident'); | |
| } |
6 tasks
abrom
added a commit
to Studiosity/sass-lint
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do the changes you have made achieve?
Are there any new warning messages?
Have you written tests?
Have you included relevant documentation
Which issues does this resolve?
Fixes #1224
DCO 1.1 Signed-off-by: Justin Anastos <justin.anastos@gmail.com>