Add unit test for ignored files #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So close! lol. |
|
Looks like the the error is that sass-lint couldn't be installed globally on node 4.0 |
Merged
Closed
|
Incoming PR to sort this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there must be no space between each ignored pattern for glob to recognize them all. I fixed that, as well as added a unit test to test against ignored files. I ran
npm testand it passed successfully.cli ✓ should return help instructions (120ms) ✓ should return a version (119ms) ✓ should not include ignored paths (461ms)...
zero unit ✓ [include: false] ✓ [include: true] 60 passing (219ms)