Hotfix Master - no-url-protocols, Fix regex for detecting url protocol use #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, just need to update the branch and we can merge it in. |
benthemonkey
force-pushed
the
hotfix/no-url-protocol-regex
branch
from
ef740de
to
193409f
Compare
|
rebased. Out of curiosity, is it poor form for me to merge in my own PRs if they have approval, pending branch update? |
|
We don't generally do it. I think it's easier for everyone to keep track with what's getting merged into develop. |
|
Update looks good. |
bgriffith
added a commit
that referenced
this pull request
Oct 23, 2015
Hotfix Master - no-url-protocols, Fix regex for detecting url protocol use
donabrams
pushed a commit
to donabrams/sass-lint
that referenced
this pull request
Nov 19, 2015
…ocol-regex Hotfix Master - no-url-protocols, Fix regex for detecting url protocol use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #340
DCO 1.1 Signed-off-by: Ben Rothman bensrothman@gmail.com