Fix no-color-literals raising warning on variables named as a color #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So we discussed this a long time ago and sort of decided against this sort of exception but I'm willing to reopen the discussion |
brettlangdon
force-pushed
the
fix-no-color-literals-map-value
branch
from
56b8ef8
to
070df8e
Compare
|
Rebased branch with |
This was referenced Apr 22, 2016
Merged
|
Thanks for your contribution @brettlangdon We carried on from the changes you made to give everyone the option to include linting of color literals in variable names or map identifiers, hopefully that solves the original issue for you too. |
|
@DanPurdy thanks! I think that will fit my needs just fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a fix for the issue outlined in #538.
DCO 1.1 Signed-off-by: Brett Langdon me@brett.is