Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertion config error - Gonzales-3.2 #588

Conversation

DanPurdy
Copy link
Member

Fixes #563

This is one I've sort of known about for a long time but finally got round to investigating it a bit.

Currently if you're using the CLI and you don't supply a path a config file or have a config file in the root of your project then the config loader throws an error to say it can't find a path. This was mainly down to the way the config loader would fall back to your package.json if it couldn't find a .sass-lint.yml file, the logic wasn't taking into account a scenario where that path wasn't specified in your package file.

This resolves it and adds a test to ensure this error doesn't reoccur.

I've pointed it towards the gonzales 3.2 update branch as I don't want to have to keep updating that one with new develop work, we may as well just load it all together in preparation for 1.6.

<DCO 1.1 Signed-off-by: Dan Purdy danjpurdy@gmail.com>

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 96.961% when pulling d920464 on DanPurdy:feature/fix-assertion-config-error into 4210db7 on sasstools:feature/gonzales-3-develop.

@DanPurdy DanPurdy changed the title Fix assertion config error Fix assertion config error - Gonzales-3.2 Mar 28, 2016
@bgriffith
Copy link
Member

Looks good.

@bgriffith bgriffith merged commit 924dd16 into sasstools:feature/gonzales-3-develop Mar 29, 2016
@DanPurdy DanPurdy deleted the feature/fix-assertion-config-error branch March 29, 2016 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants