New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BEM conventions for all naming rules #614

Merged
merged 1 commit into from Apr 17, 2016

Conversation

Projects
None yet
3 participants
@ncoden
Contributor

ncoden commented Apr 17, 2016

New PR after a git mistake in #604

Fix: #598
Changes:
Add strictbem and hyphenatedbem conventions for all naming rules:

  • function-name-format
  • mixin-name-format
  • placeholder-name-format
  • function-name-format

Add tests and examples in documentation for these naming conventions.

🔍 Add BEM conventions for all naming rules
**Fix**: #598

**Changes**:
Add `strictbem ` and `hyphenatedbem` conventions for all naming rules:
- `function-name-format`
- `mixin-name-format`
- `placeholder-name-format`
- `function-name-format`

Add tests and examples in documentation for these naming conventions.

@ncoden ncoden changed the title from :mag: Add BEM conventions for all naming rules to Add BEM conventions for all naming rules Apr 17, 2016

@ncoden

This comment has been minimized.

Contributor

ncoden commented Apr 17, 2016

ping @DanPurdy

@coveralls

This comment has been minimized.

coveralls commented Apr 17, 2016

Coverage Status

Coverage increased (+0.04%) to 96.915% when pulling ecccaa4 on ncoden:feature/bem-convention-2 into ee59893 on sasstools:develop.

@DanPurdy

This comment has been minimized.

Member

DanPurdy commented Apr 17, 2016

Awesome, thanks @ncoden! Sorry again for the hassle 😄

@sasstools/owners
Developer sign off is visible in #604

@DanPurdy DanPurdy merged commit 3825e9e into sasstools:develop Apr 17, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 96.915%
Details

@DanPurdy DanPurdy added this to the 1.6.0 - Latest Gonzales milestone Apr 17, 2016

@ncoden

This comment has been minimized.

Contributor

ncoden commented Apr 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment