Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-universal-selectors rule #695

Merged
merged 8 commits into from
May 15, 2016

Conversation

bgriffith
Copy link
Member

@bgriffith bgriffith commented May 10, 2016

What do the changes you have made achieve?

Adds a new rule no-universal-selectors

Have you written tests?

Yep

Have you included relevant documentation

Yep

Which issues does this resolve?

Relates to #694

<DCO 1.1 Signed-off-by: Ben Griffith gt11687@gmail.com>

@coveralls
Copy link

coveralls commented May 10, 2016

Coverage Status

Coverage increased (+0.01%) to 97.109% when pulling d4e5270 on bgriffith:feature/universal into 098de67 on sasstools:develop.

@bgriffith bgriffith added this to the 1.8.0 milestone May 10, 2016
@@ -0,0 +1,30 @@
# No Universal Selectors

Rule `no-universal-selectors` will enforce that the `*` (universal) selector is not allowed to be used.
Copy link
Member

@DanPurdy DanPurdy May 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't read right, Will enforce the use of universal selectors or enforce whether universal selectors can be used.. Prevent the use of... Something more like that?

@coveralls
Copy link

coveralls commented May 15, 2016

Coverage Status

Coverage increased (+0.08%) to 97.181% when pulling 1ebfffe on bgriffith:feature/universal into 098de67 on sasstools:develop.

@coveralls
Copy link

coveralls commented May 15, 2016

Coverage Status

Coverage increased (+0.01%) to 97.181% when pulling 7b29503 on bgriffith:feature/universal into 33e8d84 on sasstools:develop.

@DanPurdy
Copy link
Member

👍

@coveralls
Copy link

coveralls commented May 15, 2016

Coverage Status

Coverage increased (+0.01%) to 97.191% when pulling ed42f11 on bgriffith:feature/universal into 0c19488 on sasstools:develop.

@DanPurdy DanPurdy merged commit 65e4354 into sasstools:develop May 15, 2016
@DanPurdy DanPurdy deleted the feature/universal branch May 15, 2016 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants