Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two issues with no-misspelled-properties rule #701

Merged
merged 5 commits into from
May 11, 2016

Conversation

bgriffith
Copy link
Member

What do the changes you have made achieve?

Fix two issues ( #352, #679 ) related to the no-misspelled-properties rule

Are there any new warning messages?

No

Have you written tests?

Yes

Have you included relevant documentation

N/A

Which issues does this resolve?

Closes #352
Closes #679

<DCO 1.1 Signed-off-by: Ben Griffith gt11687@gmail.com>

@bgriffith bgriffith added this to the 1.8.0 milestone May 10, 2016
@coveralls
Copy link

coveralls commented May 10, 2016

Coverage Status

Coverage increased (+0.02%) to 97.112% when pulling 81bb14b on bgriffith:feature/no-miss-props into 098de67 on sasstools:develop.

@bgriffith
Copy link
Member Author

Need to update since older versions of node don't handle Object.assign.

@DanPurdy
Copy link
Member

Use Array.concat instead

@coveralls
Copy link

coveralls commented May 11, 2016

Coverage Status

Coverage increased (+0.02%) to 97.112% when pulling 50a859d on bgriffith:feature/no-miss-props into 6b7211a on sasstools:develop.

@DanPurdy
Copy link
Member

👍

@DanPurdy DanPurdy merged commit 0e0f98e into sasstools:develop May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property interpolation triggers misspelled properties warning Warnings for nested properties
3 participants