Absolute Path polyfill #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanPurdy
force-pushed
the
feature/absolute-polyfill
branch
from
a3a1255
to
68442f5
Compare
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the PR in #690 just so I could add node 0.10 in the test matrices again and add a slight tidy up.
Appveyor 0.10 is set to allow failures as it for some reason can't read the help text or version number that we generate, included screenshot proves that this isn't the case though.
We'll just have to be vigilant with the 0.10 tests and make sure only 2 failures get through though but it's worth keeping 0.10 support at least until it drops off the LTS list in a few months time.
Thanks to @ianand2 too for the original fix here.
<DCO 1.1 Signed-off-by: Dan Purdy dan@danpurdy.co.uk>