Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max-line-length rule #840

Merged
merged 4 commits into from
Oct 26, 2016

Conversation

DanPurdy
Copy link
Member

@DanPurdy DanPurdy commented Aug 25, 2016

Adds the max-line-length rule by default it is disabled in the config.
It specifies a default value of 80 characters long.
If a line breaches the default or user set limit it will warn with the message:
line 1 exceeds the maximum line length of 80

closes #833

<DCO 1.1 Signed-off-by: Dan Purdy dan@danpurdy.co.uk>

@coveralls
Copy link

coveralls commented Aug 25, 2016

Coverage Status

Coverage increased (+0.01%) to 97.264% when pulling ecdcc98 on DanPurdy:feature/max-line-length into 54c25a9 on sasstools:develop.

@coveralls
Copy link

coveralls commented Aug 25, 2016

Coverage Status

Coverage increased (+0.01%) to 97.264% when pulling 9836960 on DanPurdy:feature/max-line-length into 54c25a9 on sasstools:develop.

@DanPurdy
Copy link
Member Author

@bgriffith this looks to fall victim to that same CRLF .sass issue we were looking at earlier. Should i patch in here or wait for the gonzales release with that particular issue fixed?

@coveralls
Copy link

coveralls commented Oct 21, 2016

Coverage Status

Coverage increased (+0.01%) to 97.539% when pulling 4bf2237 on DanPurdy:feature/max-line-length into a66c707 on sasstools:develop.

@bgriffith
Copy link
Member

@DanPurdy Hey - is this good to go now on the CRLF front?

@DanPurdy
Copy link
Member Author

Yup if the tests are passing.

@bgriffith bgriffith added this to the 1.10 milestone Oct 26, 2016
@coveralls
Copy link

coveralls commented Oct 26, 2016

Coverage Status

Coverage increased (+0.01%) to 97.541% when pulling 5123ca5 on DanPurdy:feature/max-line-length into 8a3f293 on sasstools:develop.

@bgriffith bgriffith merged commit 4a6c345 into sasstools:develop Oct 26, 2016
@DanPurdy DanPurdy deleted the feature/max-line-length branch October 28, 2016 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule suggestion: max-line-length
3 participants